From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F87C433F5 for ; Tue, 26 Apr 2022 13:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241727AbiDZN2H (ORCPT ); Tue, 26 Apr 2022 09:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbiDZN2E (ORCPT ); Tue, 26 Apr 2022 09:28:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DA2B1189BDC for ; Tue, 26 Apr 2022 06:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650979495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qM5da8UlP3PBXWwzR2qkYcIQ1ttzUQO+1UTjPoiTGf8=; b=A10XhoCJGAGLSxuzZVUI4QUIyPThbx8wMXQ++wTcjc4duc/9cuqVWIWpv5UpoAiVLZNPgc KHpYRktIsgSWzSYKokoou+jyEGMxyPteb48839tmEkWwAM7WayIVk006F7aDMGrxHkAESX Cd0mowMOHkIaQdZGcybP3icQB/CE0Wg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-425-c0CFsn_dOpSEOuYGWY8HiQ-1; Tue, 26 Apr 2022 09:24:52 -0400 X-MC-Unique: c0CFsn_dOpSEOuYGWY8HiQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA92B8001EA; Tue, 26 Apr 2022 13:24:51 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id A69F841373D; Tue, 26 Apr 2022 13:24:51 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 6274C22067F; Tue, 26 Apr 2022 09:24:51 -0400 (EDT) Date: Tue, 26 Apr 2022 09:24:51 -0400 From: Vivek Goyal To: Miklos Szeredi Cc: Bernd Schubert , linux-fsdevel@vger.kernel.org, Jeffle Xu , Dharmendra Singh , "Dr. David Alan Gilbert" , German Maglione , Sergio Lopez Subject: Re: [PATCH] fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT flag Message-ID: References: <165002363635.1457422.5930635235733982079.stgit@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Apr 26, 2022 at 03:13:50PM +0200, Miklos Szeredi wrote: > On Tue, 26 Apr 2022 at 15:01, Vivek Goyal wrote: > > > Agree that it probably is a nice change if we had introduced this in the > > beginning itself. Its like extra saftey net. But now if we add it, it > > will break things which is not nice. So at this point of time, it probably > > is better to fix fuse servers instead and set ->flags2 to zero, IMHO. > > I think the question is whether the "unfixed" virtiofsd > implementations made it into any sort of release or not. Existing unfixed versions are already released in various releses. C version of virtiofsd is already being used in RHEL8 release and some fedora releases. And rust version of virtiofsd is supposed to be in RHEL9 beta. Hence if we change it now, it is possible older virtiofsd (unfixed one) is running on host and trying to boot a newer guest kernel and that leads to breaking things. Thanks Vivek > > If not, then I think it's fine to break unreleased versions, since > they are ephemeral anyway. > > Thanks, > Miklos >