From: Matthew Wilcox <willy@infradead.org>
To: Jagdish Gediya <jvgediya@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Jonathan.Cameron@huawei.com, adobriyan@gmail.com,
akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
rf@opensource.cirrus.com, pmladek@suse.com, ying.huang@intel.com,
dave.hansen@intel.com
Subject: Re: [PATCH v2 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool()
Date: Tue, 26 Apr 2022 18:23:51 +0100 [thread overview]
Message-ID: <Ymgqp9/DfOWAUD6c@casper.infradead.org> (raw)
In-Reply-To: <20220426170040.65487-1-jvgediya@linux.ibm.com>
On Tue, Apr 26, 2022 at 10:30:39PM +0530, Jagdish Gediya wrote:
> At many places in kernel, It is necessary to convert sysfs input
> to corrosponding bool value e.g. "false" or "0" need to be converted
> to bool false, "true" or "1" need to be converted to bool true,
> places where such conversion is needed currently check the input
> string manually, kstrtobool() can be utilized at such places but
> currently it doesn't have support to accept "false"/"true".
>
> Add support to accept "false"/"true" as valid string in kstrtobool().
>
> Signed-off-by: Jagdish Gediya <jvgediya@linux.ibm.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
... except ...
> - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or
> + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
https://en.wikipedia.org/wiki/If_and_only_if
prev parent reply other threads:[~2022-04-26 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 17:00 [PATCH v2 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Jagdish Gediya
2022-04-26 17:00 ` [PATCH v2 2/2] mm: Covert sysfs input to bool using kstrtobool() Jagdish Gediya
2022-04-26 17:24 ` Matthew Wilcox
2022-04-27 15:17 ` Andy Shevchenko
2022-05-13 1:05 ` Andrew Morton
2022-05-13 18:28 ` Alexey Dobriyan
2022-05-16 10:48 ` Jagdish Gediya
2022-05-16 10:47 ` Jagdish Gediya
2022-04-26 17:23 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymgqp9/DfOWAUD6c@casper.infradead.org \
--to=willy@infradead.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=jvgediya@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.