From: Rob Herring <robh@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Wolfram Sang <wsa@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: i2c-gpio: Add property i2c-gpio,sda-output-only
Date: Tue, 26 Apr 2022 13:56:20 -0500 [thread overview]
Message-ID: <YmhAVKOCccvt/moH@robh.at.kernel.org> (raw)
In-Reply-To: <ff31e0c7-6a59-72c3-0e46-9231ec90ce9a@gmail.com>
On Fri, Apr 15, 2022 at 03:32:47PM +0200, Heiner Kallweit wrote:
> This documents new property i2c-gpio,sda-output-only.
The diff tells me that. The commit message needs the same
justification(s) as you have in the cover letter or patch 3.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-gpio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-gpio.yaml b/Documentation/devicetree/bindings/i2c/i2c-gpio.yaml
> index fd0402845..25cd1b260 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-gpio.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-gpio.yaml
> @@ -33,6 +33,10 @@ properties:
> open drain.
> maxItems: 1
>
> + i2c-gpio,sda-output-only:
> + description: sda as output only
> + type: boolean
> +
> i2c-gpio,scl-output-only:
> description: scl as output only
> type: boolean
> --
> 2.35.3
>
>
>
next prev parent reply other threads:[~2022-04-26 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 13:31 [PATCH 0/3] i2c: gpio: support write-only sda Heiner Kallweit
2022-04-15 13:32 ` [PATCH 1/3] dt-bindings: i2c-gpio: Add property i2c-gpio,sda-output-only Heiner Kallweit
2022-04-26 18:56 ` Rob Herring [this message]
2022-04-15 13:33 ` [PATCH 2/3] i2c: algo: bit: allow getsda to be NULL Heiner Kallweit
2022-04-15 13:35 ` [PATCH 3/3] i2c: gpio: support write-only sda Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmhAVKOCccvt/moH@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.