From: Cyril Hrubis <chrubis@suse.cz>
To: "chenhx.fnst@fujitsu.com" <chenhx.fnst@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] ????: [PATCH v3] syscalls/mount_setattr01: Add basic functional test
Date: Wed, 27 Apr 2022 17:30:03 +0200 [thread overview]
Message-ID: <Ymlhe/b6mm++dMJG@yuki> (raw)
In-Reply-To: <OS3PR01MB6449E26528843CFF8CDCF30CE6FA9@OS3PR01MB6449.jpnprd01.prod.outlook.com>
Hi!
> For move_mount, we should close(fd) before umount.
Really?
And even if that was the case we can simply close the file descript
right after the move_mount() call, which would simplify things a lot.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-04-27 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 6:08 [LTP] [PATCH v3] syscalls/mount_setattr01: Add basic functional test Chen Hanxiao
2022-04-25 10:48 ` Petr Vorel
2022-04-26 10:18 ` [LTP] 回复: " chenhx.fnst
2022-04-26 12:43 ` [LTP] " Cyril Hrubis
2022-04-27 8:23 ` [LTP] 回复: " chenhx.fnst
2022-04-27 15:30 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymlhe/b6mm++dMJG@yuki \
--to=chrubis@suse.cz \
--cc=chenhx.fnst@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.