From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu <wenxu@chinatelecom.cn>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] nf_flow_table_offload: offload the vlan encap in the flowtable
Date: Wed, 27 Apr 2022 17:55:20 +0200 [thread overview]
Message-ID: <YmlnaJ2ELDhALNz8@salvia> (raw)
In-Reply-To: <42afa9bb-e265-33e7-c0dc-75d40689ade1@chinatelecom.cn>
On Wed, Apr 27, 2022 at 11:28:16PM +0800, wenxu wrote:
>
> On 2022/4/27 22:10, Pablo Neira Ayuso wrote:
> > On Tue, Apr 05, 2022 at 10:38:35AM -0400, wenx05124561@163.com wrote:
> >> From: wenxu <wenxu@chinatelecom.cn>
> >>
> >> This patch put the vlan dev process in the FLOW_OFFLOAD_XMIT_DIRECT
> >> mode. Xmit the packet with vlan can offload to the real dev directly.
> >>
> >> It can support all kinds of VLAN dev path:
> >> br0.100-->br0(vlan filter enable)-->eth
> >> br0(vlan filter enable)-->eth
> >> br0(vlan filter disable)-->eth.100-->eth
> > I assume this eth is a bridge port.
>
> Yes it is. And it also can support the case without bridge as following.
>
> eth.100-->eth.
>
> >
> >> The packet xmit and recv offload to the 'eth' in both original and
> >> reply direction.
> > This is an enhancement or fix?
>
> It's an enhancement and it make the vlan packet can offload through the real dev.
What's the benefit from the existing approach?
> > Is this going to work for VLAN + PPP?
> >
> > Would you update tools/testing/selftests/netfilter/nft_flowtable.sh to
> > cover bridge filtering usecase? It could be done in a follow up patch.
>
> I will do for both if this patch reivew ok .
OK.
next prev parent reply other threads:[~2022-04-27 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 14:38 [PATCH nf-next] nf_flow_table_offload: offload the vlan encap in the flowtable wenx05124561
2022-04-27 14:10 ` Pablo Neira Ayuso
2022-04-27 15:28 ` wenxu
2022-04-27 15:55 ` Pablo Neira Ayuso [this message]
2022-04-27 16:30 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlnaJ2ELDhALNz8@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wenxu@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.