From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Wed, 27 Apr 2022 13:44:52 -0500 Subject: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples In-Reply-To: References: <20220422192139.2592632-1-robh@kernel.org> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: > > > > The additional nodes in the example referenced from the pinctrl node > > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) > > or not documented with a schema (aspeed,ast2500-gfx). There's no need to > > show these nodes as part of the pinctrl example, so just remove them. > > > > Signed-off-by: Rob Herring > > Nak. I welcome patches that add schemas for the undocumented compatibles instead. Otherwise, I will be turning on this check by default and nagging people to fix them. > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? How is what the 'gfx' and 'lpc' nodes contain relevant to how the pinctrl binding works? If a user wants to know, then they should go look at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their examples. Which brings up my secondary issue which is having the same example multiple times. It is multiple chances for errors (that I end up fixing). How do we know the example is even correct without any schema checks? The 'framebuffer' node is not in a valid location is the most obvious thing I see. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D3BC433FE for ; Wed, 27 Apr 2022 18:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbiD0S7k (ORCPT ); Wed, 27 Apr 2022 14:59:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbiD0S7Y (ORCPT ); Wed, 27 Apr 2022 14:59:24 -0400 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E67561611DF; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) Received: by mail-oi1-f181.google.com with SMTP id q8so2517951oif.13; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/sIxYWvFlMoHReoMPfX2NBRTuxsiKhz/pal5GhylPqg=; b=PN/WCN/lJCiNMu10xuaOmS9MxjYy07TYnJnbrxcJxLZ1TetHbPoXZQtIfiGNYcxKtD lh3/cwwSi0xfgQxrTnIyDXEaRD/wMRqiN6NcusaHLhw+A9kvsWOfH2Y5uUgPciYzEgWU RtA5WbOPgWpURhbmCrMoZ85lPvmLo+w63G6yJP4A1uUpXWUijK/sYZ8pwb+tN5vTmyb0 mClV+PlUfZimMiAfTqOvbIet7GAB+LuJguREm3pu7i6KWwrq5cBdbehwRL9jFj+ut3SZ 951R6nbqKUJihdotbl6MQzzXG+aSTSZnsAQgde5y1V5kuGZcZRvFnFIOsoSHYjm2UaKw 2Axg== X-Gm-Message-State: AOAM532FkCy6BldeuvC7cvcCzGG6kmifJNV4yPSX/SvNxTYXZOT3c1Rl R6SKLatMnpp0kukK0paBXg== X-Google-Smtp-Source: ABdhPJz6nKdb0AwwSKP/n1AYikKnnui7VO1eKjkTuDHiUj8S52Lm4O++NP3zOk3jiqIIDRQN/19pQA== X-Received: by 2002:aca:1a09:0:b0:325:90ab:a812 with SMTP id a9-20020aca1a09000000b0032590aba812mr1384519oia.131.1651085093218; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m4-20020a056870030400b000e686d13890sm963611oaf.42.2022.04.27.11.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 11:44:52 -0700 (PDT) Received: (nullmailer pid 436853 invoked by uid 1000); Wed, 27 Apr 2022 18:44:52 -0000 Date: Wed, 27 Apr 2022 13:44:52 -0500 From: Rob Herring To: Joel Stanley Cc: Andrew Jeffery , Linus Walleij , Krzysztof Kozlowski , linux-aspeed , OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , devicetree , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Message-ID: References: <20220422192139.2592632-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: > > > > The additional nodes in the example referenced from the pinctrl node > > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) > > or not documented with a schema (aspeed,ast2500-gfx). There's no need to > > show these nodes as part of the pinctrl example, so just remove them. > > > > Signed-off-by: Rob Herring > > Nak. I welcome patches that add schemas for the undocumented compatibles instead. Otherwise, I will be turning on this check by default and nagging people to fix them. > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? How is what the 'gfx' and 'lpc' nodes contain relevant to how the pinctrl binding works? If a user wants to know, then they should go look at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their examples. Which brings up my secondary issue which is having the same example multiple times. It is multiple chances for errors (that I end up fixing). How do we know the example is even correct without any schema checks? The 'framebuffer' node is not in a valid location is the most obvious thing I see. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14D95C433F5 for ; Wed, 27 Apr 2022 18:45:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KpSP11HnTz3bck for ; Thu, 28 Apr 2022 04:45:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.177; helo=mail-oi1-f177.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KpSNS49dQz2x9W; Thu, 28 Apr 2022 04:44:55 +1000 (AEST) Received: by mail-oi1-f177.google.com with SMTP id e189so2924868oia.8; Wed, 27 Apr 2022 11:44:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/sIxYWvFlMoHReoMPfX2NBRTuxsiKhz/pal5GhylPqg=; b=58AQ4PoYwAKv+EpB1asqlygstMrwwI1sbparJHTk2hdFEJNbCrK22ySHrAlrJOBcNl xLnl3R7sBuJ4DFwZv9GNVfOHw0MJdRNf+LwTBmw2UwrwaV/l/SzWIElheGEod8bFHipB o+JWqXARzXF4Qf8othUuEkAlAURUVBSH/oq/EDvMb7oRYWswEXN65Uvpe/OBfbd0kBDp fm8VptoN2vWm8BM1nDeWiR/FLiunEBhveF0cmUwfFLC0ioAg6pklWK34DBULknmg22Sf GnMiLEqfZxn612uPkFzpqU+30J1IibqENhsJ+L1SsA1H+FVTR3OoztK2VpTOjsK8WKp3 EItg== X-Gm-Message-State: AOAM533t7XYm0D8Ol9FQHffzI7tvCcDdzj0QQ+X2Fg0/+lYN2Ujalw6W Sq13UC6b29rBXWzWzWB9pw== X-Google-Smtp-Source: ABdhPJz6nKdb0AwwSKP/n1AYikKnnui7VO1eKjkTuDHiUj8S52Lm4O++NP3zOk3jiqIIDRQN/19pQA== X-Received: by 2002:aca:1a09:0:b0:325:90ab:a812 with SMTP id a9-20020aca1a09000000b0032590aba812mr1384519oia.131.1651085093218; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m4-20020a056870030400b000e686d13890sm963611oaf.42.2022.04.27.11.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 11:44:52 -0700 (PDT) Received: (nullmailer pid 436853 invoked by uid 1000); Wed, 27 Apr 2022 18:44:52 -0000 Date: Wed, 27 Apr 2022 13:44:52 -0500 From: Rob Herring To: Joel Stanley Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Message-ID: References: <20220422192139.2592632-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Krzysztof Kozlowski , OpenBMC Maillist , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: > > > > The additional nodes in the example referenced from the pinctrl node > > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) > > or not documented with a schema (aspeed,ast2500-gfx). There's no need to > > show these nodes as part of the pinctrl example, so just remove them. > > > > Signed-off-by: Rob Herring > > Nak. I welcome patches that add schemas for the undocumented compatibles instead. Otherwise, I will be turning on this check by default and nagging people to fix them. > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? How is what the 'gfx' and 'lpc' nodes contain relevant to how the pinctrl binding works? If a user wants to know, then they should go look at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their examples. Which brings up my secondary issue which is having the same example multiple times. It is multiple chances for errors (that I end up fixing). How do we know the example is even correct without any schema checks? The 'framebuffer' node is not in a valid location is the most obvious thing I see. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40F0CC433FE for ; Wed, 27 Apr 2022 18:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6h7ow8WKJmxx1mWLmTbPrJLa399UMhNuCVpsyuN1+Ag=; b=CK/0V3OkuBJE/p zcyNMHOgDVqpOTe/EzTtKp2ApiHr7sQgIOpay6qwiHjC/6B+g/xkA4LHGxvvZd51vGZUEEKjwtUbv 7RLHFSwBpT/ENeyGtae5xdPkWlShG1EzweV8EIsQTsnLp5JrgNjnoBAYpkwJDJAbSI5fq9ZiCcSAi X7gLtXDwAmz8WRixb9GFPGqr4xTbw5JJZx2uzWtxw2MfiV4YUmGiTyEi8TGzU1Nu055lNEgH4peBc 7gzQaWbp7NcAQhjXuAfZwdfqAH0tN1+n9TWkyft46vAFMgibdfPS8h1a61oEQkSmfbNy/9G5qlLY9 pyDPZEWms19v1p9FKY6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njmer-0036dR-7S; Wed, 27 Apr 2022 18:45:01 +0000 Received: from mail-oi1-f181.google.com ([209.85.167.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njmem-0036aa-Lb for linux-arm-kernel@lists.infradead.org; Wed, 27 Apr 2022 18:44:58 +0000 Received: by mail-oi1-f181.google.com with SMTP id a10so2923911oif.9 for ; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/sIxYWvFlMoHReoMPfX2NBRTuxsiKhz/pal5GhylPqg=; b=LkSjQWmFhuqhsoMQGMGczw1lklR7B5cZy+mhRopUFN29Iq3qFEgg8kiQmar3Q+8KXr oieadExygpcnqXygn0sBhiuW7NaaW4HXWBlzbm5s/QCqfemRTBInpYeL2iqxjsY5CM46 WVE/QxsaIDRaA9cy7+U2v9MRyQ4l/jfbTGinPJjrkUYDAvWMT81YJL7Le9WDtwUsf35e tE8aIjVPO41PsMsJBznHCeyrjfrqeATZ0ngTgGLLBqJhumCMqz3WkK1wWYJ45HvVugHX PzCiQx8qe+99+2YdYd1XJaKwelgq2UBsl/+aa24q4QOn+F7TSw1iikhLij94Wk1i+A7Y SxFA== X-Gm-Message-State: AOAM533xM0YIPJlbKAZj8tnwScVayd43TCaqKQbfOGoZjhc5gb8b1+P7 EQZuWvMD6Cqp8CqLXWKQP69bgE9nyg== X-Google-Smtp-Source: ABdhPJz6nKdb0AwwSKP/n1AYikKnnui7VO1eKjkTuDHiUj8S52Lm4O++NP3zOk3jiqIIDRQN/19pQA== X-Received: by 2002:aca:1a09:0:b0:325:90ab:a812 with SMTP id a9-20020aca1a09000000b0032590aba812mr1384519oia.131.1651085093218; Wed, 27 Apr 2022 11:44:53 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m4-20020a056870030400b000e686d13890sm963611oaf.42.2022.04.27.11.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 11:44:52 -0700 (PDT) Received: (nullmailer pid 436853 invoked by uid 1000); Wed, 27 Apr 2022 18:44:52 -0000 Date: Wed, 27 Apr 2022 13:44:52 -0500 From: Rob Herring To: Joel Stanley Cc: Andrew Jeffery , Linus Walleij , Krzysztof Kozlowski , linux-aspeed , OpenBMC Maillist , "open list:GPIO SUBSYSTEM" , devicetree , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Drop referenced nodes in examples Message-ID: References: <20220422192139.2592632-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_114456_757983_58EF1EA3 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 27, 2022 at 08:40:31AM +0000, Joel Stanley wrote: > On Fri, 22 Apr 2022 at 19:21, Rob Herring wrote: > > > > The additional nodes in the example referenced from the pinctrl node > > 'aspeed,external-nodes' properties are either incorrect (aspeed,ast2500-lpc) > > or not documented with a schema (aspeed,ast2500-gfx). There's no need to > > show these nodes as part of the pinctrl example, so just remove them. > > > > Signed-off-by: Rob Herring > > Nak. I welcome patches that add schemas for the undocumented compatibles instead. Otherwise, I will be turning on this check by default and nagging people to fix them. > This removes the information on how to use the bindings. Surely we > prefer to over document rather than under document? How is what the 'gfx' and 'lpc' nodes contain relevant to how the pinctrl binding works? If a user wants to know, then they should go look at the aspeed,ast2500-lpc/aspeed,ast2500-gfx bindings and their examples. Which brings up my secondary issue which is having the same example multiple times. It is multiple chances for errors (that I end up fixing). How do we know the example is even correct without any schema checks? The 'framebuffer' node is not in a valid location is the most obvious thing I see. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel