From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33001C433F5 for ; Thu, 28 Apr 2022 05:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id E8650C385AE; Thu, 28 Apr 2022 05:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66BFCC385A9; Thu, 28 Apr 2022 05:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651124734; bh=A3XvUYr/VhPRon0+LWzgmvQmq2CIOL0bUGl/5SAld5g=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=XrWyUQGig/e8RHE8UiuZDaw2PjI5Tla8Tt/fO/NGoMwUGgkLbemXNtVK8R2B7BFIU 2RBFWDaY3DT+oseiFGHr+Kc1VfMw4vR5KcB4eVTIlfzJSxBAcqKDRoqWu+7aPYi7Nd s+3NvpTcwer4un31kiDfb0sFWpnhi7Zjg0BNvbpM= Date: Thu, 28 Apr 2022 07:45:26 +0200 From: "gregkh@linuxfoundation.org" To: "hasegawa-hitomi@fujitsu.com" List-Id: Cc: Daniel Thompson , Arnd Bergmann , Linux ARM , SoC Team , "open list:SERIAL DRIVERS" , Sumit Garg , Olof Johansson , Catalin Marinas , Will Deacon , Jiri Slaby , Jason Wessel , Doug Anderson , Linux Kernel Mailing List , "kgdb-bugreport@lists.sourceforge.net" , Peter Zijlstra , Mike Travis Subject: Re: [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver Message-ID: References: <20220331092235.3000787-2-hasegawa-hitomi@fujitsu.com> <20220408133246.fyw5554lgli4olvg@maple.lan> <20220408150202.yhn3qppqwm7wzmo3@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 28, 2022 at 02:15:52AM +0000, hasegawa-hitomi@fujitsu.com wrote: > Hi Greg, Arnd, and Daniel, > > > I understand that it is not appropriate to hardcode c. > > How about using __setup() to add a new kernel parameter and allow the admin > > to specify the sysrq command when booting? > > I have received a lot of advice regarding sysrq, but after some consideration, > I would like to change to calling panic() directly as in v1 instead of sysrq. panic() seems good to me! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B3F3C433EF for ; Thu, 28 Apr 2022 05:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uhLEWYCFM5X4jTpmKSuPxXGeFwoLOG871tpgYxyQ6Ww=; b=1oXJLXftqgLOCO QHBhgegHZ9EFlAz58ASVWYNIJB52Sw6Nb04Wg/aGvjgW4AfSCfq8bj1HRJklhoJAKCteKGHoAgNyP WdmuSnX2sUiANvJd+AtUxnIIYQ/rymrxW2PpHVQx4o8jf3A8gh9WgHIWLxnR6gxFAEpi4R1ZF/n3v KTgkbugHDNwRodz/risG8VYpW+VFDKU9l2xKKmug8G1/M/2SV+SIzekpheLynFcpoLcNuLI332Xnl 9FAeqm8/8FdlzaELRR3E8vcPjIcUB/pBhgHnFQI7rZc/ZYX3a4a8qAWVLqR0yZHtCHI7k2s35oOrD ryBubCFAxVZqrPpWh6kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njwyB-004luD-6m; Thu, 28 Apr 2022 05:45:39 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njwy8-004ltJ-8z for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 05:45:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4AE461CEF; Thu, 28 Apr 2022 05:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66BFCC385A9; Thu, 28 Apr 2022 05:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651124734; bh=A3XvUYr/VhPRon0+LWzgmvQmq2CIOL0bUGl/5SAld5g=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=XrWyUQGig/e8RHE8UiuZDaw2PjI5Tla8Tt/fO/NGoMwUGgkLbemXNtVK8R2B7BFIU 2RBFWDaY3DT+oseiFGHr+Kc1VfMw4vR5KcB4eVTIlfzJSxBAcqKDRoqWu+7aPYi7Nd s+3NvpTcwer4un31kiDfb0sFWpnhi7Zjg0BNvbpM= Date: Thu, 28 Apr 2022 07:45:26 +0200 From: "gregkh@linuxfoundation.org" To: "hasegawa-hitomi@fujitsu.com" Cc: Daniel Thompson , Arnd Bergmann , Linux ARM , SoC Team , "open list:SERIAL DRIVERS" , Sumit Garg , Olof Johansson , Catalin Marinas , Will Deacon , Jiri Slaby , Jason Wessel , Doug Anderson , Linux Kernel Mailing List , "kgdb-bugreport@lists.sourceforge.net" , Peter Zijlstra , Mike Travis Subject: Re: [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver Message-ID: References: <20220331092235.3000787-2-hasegawa-hitomi@fujitsu.com> <20220408133246.fyw5554lgli4olvg@maple.lan> <20220408150202.yhn3qppqwm7wzmo3@maple.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_224536_389918_F57F2305 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 28, 2022 at 02:15:52AM +0000, hasegawa-hitomi@fujitsu.com wrote: > Hi Greg, Arnd, and Daniel, > > > I understand that it is not appropriate to hardcode c. > > How about using __setup() to add a new kernel parameter and allow the admin > > to specify the sysrq command when booting? > > I have received a lot of advice regarding sysrq, but after some consideration, > I would like to change to calling panic() directly as in v1 instead of sysrq. panic() seems good to me! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel