Re: [LTP] [PATCH v5] syscalls/mount_setattr01: Add basic functional test

[Petr Vorel <pvorel@suse.cz>]

Hi Dai, Chen,

Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, waiting for Cyril's final ack before merging.

> diff --git a/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c b/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c
...
> +#define MNTPOINT        "mntpoint"
> +#define OT_MNTPOINT     "ot_mntpoint"
> +#define TCASE_ENTRY(attrs, exp_attrs)   \
> +	{                                \
> +		.name = #attrs,                 \
> +		.mount_attrs = attrs,           \
> +		.expect_attrs = exp_attrs       \
> +	}
nit: This is absolutely ok, but I'd personally use the version from v2, which
set only .name and .mount_attrs (the only point for macros are to reduce
duplicity, which is not in passing .expect_attrs).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp