From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C85C433EF for ; Fri, 29 Apr 2022 11:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239211AbiD2LJh (ORCPT ); Fri, 29 Apr 2022 07:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239174AbiD2LJh (ORCPT ); Fri, 29 Apr 2022 07:09:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 658122BB3E; Fri, 29 Apr 2022 04:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fMdiNIX6IDBT9DuqskkT0WgA7a07Qd6BHjsFV1ujKlo=; b=e0dW1trDuU4PBeSW86P1pgQAS2 2nuk5t5yASP8KqGzPRbvt0cBRTGQ7fIQFj2mSk4QyXZ8ZyYIkeBv0PaxcrWTXMqk6H+SYFKBX8Gjk i+k8F9N2XDatZdkQgtWGtd3COYPMeU97bH5edEhyCRWPoXhpo9S3dHdil45qQ+azZc7Agi4z5fPHe JsoKfPCkxdraIkwe2QDF871CPa2nonymoBcR9emMbsuqiu35DXqp3jo3xxmRLii2o7ufNJvPG7E07 dsmSSsJdMNycNv+RQjG68xGFBqVLnisrF36wBic9JiA7JRONwm5w75MrdFr2Misi7tg2J8tGKO0qs m6HNZXYA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkORa-00CLBP-JT; Fri, 29 Apr 2022 11:05:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9A312300385; Fri, 29 Apr 2022 13:05:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7E49320295B05; Fri, 29 Apr 2022 13:05:49 +0200 (CEST) Date: Fri, 29 Apr 2022 13:05:49 +0200 From: Peter Zijlstra To: Chen Zhongjin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, masahiroy@kernel.org, jpoimboe@redhat.com, ycote@redhat.com, herbert@gondor.apana.org.au, mark.rutland@arm.com, davem@davemloft.net, ardb@kernel.org, maz@kernel.org, tglx@linutronix.de, luc.vanoostenryck@gmail.com Subject: Re: [RFC PATCH v4 22/37] arm64: kernel: Skip validation of kuser32.o Message-ID: References: <20220429094355.122389-1-chenzhongjin@huawei.com> <20220429094355.122389-23-chenzhongjin@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429094355.122389-23-chenzhongjin@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Apr 29, 2022 at 05:43:40PM +0800, Chen Zhongjin wrote: > From: Raphael Gault > > kuser32 being used for compatibility, it contains a32 instructions > which are not recognised by objtool when trying to analyse arm64 > object files. Thus, we add an exception to skip validation on this > particular file. > > Signed-off-by: Raphael Gault > Signed-off-by: Julien Thierry > Signed-off-by: Chen Zhongjin > --- > arch/arm64/kernel/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile > index 986837d7ec82..c4f01bfe79b4 100644 > --- a/arch/arm64/kernel/Makefile > +++ b/arch/arm64/kernel/Makefile > @@ -41,6 +41,9 @@ obj-$(CONFIG_COMPAT) += sys32.o signal32.o \ > sys_compat.o > obj-$(CONFIG_COMPAT) += sigreturn32.o > obj-$(CONFIG_KUSER_HELPERS) += kuser32.o > + > +OBJECT_FILES_NON_STANDARD_kuser32.o := y File based skipping is depricated in the face of LTO and other link target based objtool runs. Please use function based blacklisting as per the previous patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A75E3C433F5 for ; Fri, 29 Apr 2022 11:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RX0q9UzFRXNxEyrJZ9AFlRnaNj/+mLb6fO600pHWvlc=; b=ZV/VlybMYKDGS3 YFkxCKrVQkEOJhFJglu31FcS33W3wVR0E/91u1Caio73TT1vgg7b2LCsiyJ53QSuDR442spmCSuaW USej282LnRYrStFrAp/jlullzB4qEZbqOq7tsLjKDIkV6CVW+pWNGn0g2/+zfNs7ptUNz1NysVT2L Uy6gQjIschV4l1ajZYv6j6mvsBDn8nsiv0LmMAzMzG7BcEMQeO2rb6VR3aHpWQLHiGVaU7vgNgFrs iU/nrXbMZSvG8MIo36ESvagFiR0mq0GamXKjqKVR5sQxkT3dVP2tVbVpieHSu3akwjAt0OC+3v//5 kEdVw4cOPd/vmiaZT3Yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkORk-00Av7B-4Q; Fri, 29 Apr 2022 11:06:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkORi-00Av75-Eq for linux-arm-kernel@bombadil.infradead.org; Fri, 29 Apr 2022 11:05:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fMdiNIX6IDBT9DuqskkT0WgA7a07Qd6BHjsFV1ujKlo=; b=e0dW1trDuU4PBeSW86P1pgQAS2 2nuk5t5yASP8KqGzPRbvt0cBRTGQ7fIQFj2mSk4QyXZ8ZyYIkeBv0PaxcrWTXMqk6H+SYFKBX8Gjk i+k8F9N2XDatZdkQgtWGtd3COYPMeU97bH5edEhyCRWPoXhpo9S3dHdil45qQ+azZc7Agi4z5fPHe JsoKfPCkxdraIkwe2QDF871CPa2nonymoBcR9emMbsuqiu35DXqp3jo3xxmRLii2o7ufNJvPG7E07 dsmSSsJdMNycNv+RQjG68xGFBqVLnisrF36wBic9JiA7JRONwm5w75MrdFr2Misi7tg2J8tGKO0qs m6HNZXYA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkORa-00CLBP-JT; Fri, 29 Apr 2022 11:05:50 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9A312300385; Fri, 29 Apr 2022 13:05:49 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7E49320295B05; Fri, 29 Apr 2022 13:05:49 +0200 (CEST) Date: Fri, 29 Apr 2022 13:05:49 +0200 From: Peter Zijlstra To: Chen Zhongjin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, masahiroy@kernel.org, jpoimboe@redhat.com, ycote@redhat.com, herbert@gondor.apana.org.au, mark.rutland@arm.com, davem@davemloft.net, ardb@kernel.org, maz@kernel.org, tglx@linutronix.de, luc.vanoostenryck@gmail.com Subject: Re: [RFC PATCH v4 22/37] arm64: kernel: Skip validation of kuser32.o Message-ID: References: <20220429094355.122389-1-chenzhongjin@huawei.com> <20220429094355.122389-23-chenzhongjin@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220429094355.122389-23-chenzhongjin@huawei.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 29, 2022 at 05:43:40PM +0800, Chen Zhongjin wrote: > From: Raphael Gault > > kuser32 being used for compatibility, it contains a32 instructions > which are not recognised by objtool when trying to analyse arm64 > object files. Thus, we add an exception to skip validation on this > particular file. > > Signed-off-by: Raphael Gault > Signed-off-by: Julien Thierry > Signed-off-by: Chen Zhongjin > --- > arch/arm64/kernel/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile > index 986837d7ec82..c4f01bfe79b4 100644 > --- a/arch/arm64/kernel/Makefile > +++ b/arch/arm64/kernel/Makefile > @@ -41,6 +41,9 @@ obj-$(CONFIG_COMPAT) += sys32.o signal32.o \ > sys_compat.o > obj-$(CONFIG_COMPAT) += sigreturn32.o > obj-$(CONFIG_KUSER_HELPERS) += kuser32.o > + > +OBJECT_FILES_NON_STANDARD_kuser32.o := y File based skipping is depricated in the face of LTO and other link target based objtool runs. Please use function based blacklisting as per the previous patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel