All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Nuno Gonçalves" <nunojpg@gmail.com>,
	"Tomasz Mon" <tomasz.mon@camlingroup.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v2] serial: pl011: UPSTAT_AUTORTS requires .throttle/unthrottle
Date: Fri, 29 Apr 2022 14:12:05 +0200	[thread overview]
Message-ID: <YmvWFQultpccovgb@kroah.com> (raw)
In-Reply-To: <d4f254ec-b73-786c-dc47-629aab8a49df@linux.intel.com>

On Fri, Apr 29, 2022 at 02:57:16PM +0300, Ilpo Järvinen wrote:
> The driver must provide throttle and unthrottle in uart_ops when it
> sets UPSTAT_AUTORTS. Add them using existing stop_rx &
> enable_interrupts functions.
> 
> Compile tested (w/o linking).

That shouldn't be here at all, put it below the --- line if its needed.


> 
> Reported-by: Nuno Gonçalves <nunojpg@gmail.com>
> Fixes: 2a76fa283098 (serial: pl011: Adopt generic flag to store auto
> 		     RTS status)

Nit, this should be all in one line.

> Cc: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Any reason why you are not cc:ing all the needed people as per
scripts/get_maintainer.pl?

thanks,

greg k-h

  reply	other threads:[~2022-04-29 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 11:57 [PATCH v2] serial: pl011: UPSTAT_AUTORTS requires .throttle/unthrottle Ilpo Järvinen
2022-04-29 12:12 ` Greg KH [this message]
2022-04-29 12:33   ` Ilpo Järvinen
2022-05-05 20:24     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmvWFQultpccovgb@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=nunojpg@gmail.com \
    --cc=tomasz.mon@camlingroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.