From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02626C433F5 for ; Fri, 29 Apr 2022 12:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NbPsdYXQBFnStMr3EO886EdAzT1qY4hNHJErsZzLSOs=; b=pgi3vGaekZ3mq2 9bpCany6EM60FQkSSp149kaCp5FgtVNyuQsFXac9WWzggryd7agEoedpkH823aOrXYn0RSphy2L9t qDvRg67SosqpIWor/HWmc4B/t6fg5s2iPV9Vn4zsrgj0iZLUPXlhdB4AWtod7/Rw12zYcK9r3yJY3 0E23esT9JBz0oN3I+Dpkg4G/eBTt58oUAAHFJkh/EBfGxIk+tAtNCz7q+pkfXu9lP3BI+/XdOmGeL 59S7dQ58gacjfnTTvI6GA1/NqCMCLupa2qjBqmEpBSVvy0xA/pJ+OXGb0/QhpyCGiR4m62eI/2Z3O BAI2arzZCoQTTJJxuJaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkPlz-00B8KZ-Ui; Fri, 29 Apr 2022 12:31:00 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkPlx-00B8JI-6Z for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 12:30:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=cf+KDXJI4wkmbU7OdoHHLR/cXtVxtK7S51UOvLfdoAY=; b=i9 uzb+BzyHswZ0FopHMlj9Sd6WwBQTTNZkISdSlSCOqJLFaX8bPUdzBW/sLHt6hQU0Njmk0exQjSOri GiMxXk506nlCbULXBVZ6nEo5hIHIpaV8mvbIIZh2ZIsJJpS8Uf7QlAzlK9ZBdYq/fWuEbQq8zMLFJ KAhHZITb+l2ijjo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkPlt-000ThK-I0; Fri, 29 Apr 2022 14:30:53 +0200 Date: Fri, 29 Apr 2022 14:30:53 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1 Message-ID: References: <20220425113706.29310-1-pali@kernel.org> <20220425113706.29310-2-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220425113706.29310-2-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_053057_285668_3FB15202 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 25, 2022 at 01:37:06PM +0200, Pali Roh=E1r wrote: > IRQs 0 and 1 cannot be mapped, they are handled internally by this driver > and this driver does not call generic_handle_domain_irq() for these IRQs. > So do not allow mapping these IRQs and correctly propagate error from the > .irq_map callback. So you are referring to this? /* Check if the interrupt is not masked on current CPU. * Test IRQ (0-1) and FIQ (8-9) mask bits. */ if (!(irqsrc & ARMADA_370_XP_INT_IRQ_FIQ_MASK(cpuid))) continue; if (irqn =3D=3D 1) { armada_370_xp_handle_msi_irq(NULL, true); continue; } Should the two FIQ interrupts also return -EINVAL? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27FEC433EF for ; Fri, 29 Apr 2022 12:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359241AbiD2MeT (ORCPT ); Fri, 29 Apr 2022 08:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359174AbiD2MeR (ORCPT ); Fri, 29 Apr 2022 08:34:17 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 275B58567A for ; Fri, 29 Apr 2022 05:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=cf+KDXJI4wkmbU7OdoHHLR/cXtVxtK7S51UOvLfdoAY=; b=i9 uzb+BzyHswZ0FopHMlj9Sd6WwBQTTNZkISdSlSCOqJLFaX8bPUdzBW/sLHt6hQU0Njmk0exQjSOri GiMxXk506nlCbULXBVZ6nEo5hIHIpaV8mvbIIZh2ZIsJJpS8Uf7QlAzlK9ZBdYq/fWuEbQq8zMLFJ KAhHZITb+l2ijjo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nkPlt-000ThK-I0; Fri, 29 Apr 2022 14:30:53 +0200 Date: Fri, 29 Apr 2022 14:30:53 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1 Message-ID: References: <20220425113706.29310-1-pali@kernel.org> <20220425113706.29310-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220425113706.29310-2-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2022 at 01:37:06PM +0200, Pali Rohár wrote: > IRQs 0 and 1 cannot be mapped, they are handled internally by this driver > and this driver does not call generic_handle_domain_irq() for these IRQs. > So do not allow mapping these IRQs and correctly propagate error from the > .irq_map callback. So you are referring to this? /* Check if the interrupt is not masked on current CPU. * Test IRQ (0-1) and FIQ (8-9) mask bits. */ if (!(irqsrc & ARMADA_370_XP_INT_IRQ_FIQ_MASK(cpuid))) continue; if (irqn == 1) { armada_370_xp_handle_msi_irq(NULL, true); continue; } Should the two FIQ interrupts also return -EINVAL? Andrew