From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F63BC433F5 for ; Fri, 29 Apr 2022 15:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x9I7VP70HD6CYsQ6MJhzjpFmnjDZ8D4lKTBPKUVRxnw=; b=TTNxCD/NkkcBBj 0brbGE3pW+cGZ6vgjNKEhlJLrLa9j0Q1ykyAI5V2LEzO965t+dahZ4WSl7zdlX3nvnRXmB13kIwUu OymsQ7oD7vOTb1QtJoBKGVD+hjJGitVUBTJW0UwFh4RhNts14WkvWNICzbz1OBRDduEc982rjmAGv W9UVkhxMmxZTKUu1UQQKMVGjQfxG3ULKcIWQjyDwqkTaD/OfqQ5hWrf5HSUKlaHGWUGaT8X85EaOB VzB4fn/aBuPTd1SFK4YcDAFWTLIue4RA6FKmf6NJoOtS2L085RJWom/a1VtkSMSxqQg1gsLlF7Tqq dqgV8pmf+v0PdNA9Ucyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkSP6-00Bk4d-FV; Fri, 29 Apr 2022 15:19:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkSP3-00Bk4B-FY for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 15:19:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PPEhKtF0sbeyujzm9thZEDJXkLxwy3zvWFKn/rMauzg=; b=pyJ3fGMrzIjrPqmogJnmqGVwL9 wgbSjJSFApC9+hZGKIuVIsHA2YByvO1vYQpx2Ik7LXVsoALcsE9G0Gmigyk3Ez1pyfd8g4CLXZqpj 9h9MPMuHoN4KykqBBkfjbG7SnzXneSRJsGcHLy+hXv70MAxhQRLG4vwGFbXyi93vmfNuBNnRLVXSN nMz4lQpp4850iFRYrVsrVz2piZbGEnCddja+jgw8qpioI8TmHTkKdQWeLcm8Bs6BMwfn4pMS60Fh/ FP6Vz7RvJkAKAVue13EySfL1anrmNqOOrEutnjpIwqWxFe6185QcTGoP8FduHitU3WRRO7Wg4Noi+ 8kBlSgxA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58442) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nkSOv-0004BC-Q4; Fri, 29 Apr 2022 16:19:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nkSOp-00022l-UK; Fri, 29 Apr 2022 16:19:15 +0100 Date: Fri, 29 Apr 2022 16:19:15 +0100 From: "Russell King (Oracle)" To: xkernel.wang@foxmail.com Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mvebu: check the validation of memory allocation Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_081929_557930_BEA254A6 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 25, 2022 at 04:55:18PM +0800, xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang > > kzalloc() and kstrdup() are memory allocation functions which can return > NULL when some internal memory errors happen. So it is better to check > the return value of them to prevent potential wrong memory access or > memory leak. Are these failures silent, or will they be reported in the kernel log to make their failure obvious to those who debug the kernel? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6160DC433EF for ; Fri, 29 Apr 2022 15:19:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378294AbiD2PWt (ORCPT ); Fri, 29 Apr 2022 11:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352753AbiD2PWs (ORCPT ); Fri, 29 Apr 2022 11:22:48 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52277D4C97 for ; Fri, 29 Apr 2022 08:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PPEhKtF0sbeyujzm9thZEDJXkLxwy3zvWFKn/rMauzg=; b=pyJ3fGMrzIjrPqmogJnmqGVwL9 wgbSjJSFApC9+hZGKIuVIsHA2YByvO1vYQpx2Ik7LXVsoALcsE9G0Gmigyk3Ez1pyfd8g4CLXZqpj 9h9MPMuHoN4KykqBBkfjbG7SnzXneSRJsGcHLy+hXv70MAxhQRLG4vwGFbXyi93vmfNuBNnRLVXSN nMz4lQpp4850iFRYrVsrVz2piZbGEnCddja+jgw8qpioI8TmHTkKdQWeLcm8Bs6BMwfn4pMS60Fh/ FP6Vz7RvJkAKAVue13EySfL1anrmNqOOrEutnjpIwqWxFe6185QcTGoP8FduHitU3WRRO7Wg4Noi+ 8kBlSgxA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58442) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nkSOv-0004BC-Q4; Fri, 29 Apr 2022 16:19:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nkSOp-00022l-UK; Fri, 29 Apr 2022 16:19:15 +0100 Date: Fri, 29 Apr 2022 16:19:15 +0100 From: "Russell King (Oracle)" To: xkernel.wang@foxmail.com Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mvebu: check the validation of memory allocation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2022 at 04:55:18PM +0800, xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang > > kzalloc() and kstrdup() are memory allocation functions which can return > NULL when some internal memory errors happen. So it is better to check > the return value of them to prevent potential wrong memory access or > memory leak. Are these failures silent, or will they be reported in the kernel log to make their failure obvious to those who debug the kernel? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!