From: Phil Sutter <phil@nwl.cc>
To: Nick Hainke <vincent@systemli.org>
Cc: netfilter-devel@vger.kernel.org, "Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH iptables 1/2] xtables: fix compilation with musl
Date: Sat, 14 May 2022 19:04:48 +0200 [thread overview]
Message-ID: <Yn/hMODAkEEbzQno@orbyte.nwl.cc> (raw)
In-Reply-To: <20220514163325.54266-1-vincent@systemli.org>
Hi,
On Sat, May 14, 2022 at 06:33:24PM +0200, Nick Hainke wrote:
> Only include <linux/if_ether.h> if glibc is used.
This looks like a bug in musl? OTOH explicit include of linux/if_ether.h
was added in commit c5d9a723b5159 ("fix build for missing ETH_ALEN
definition"), despite netinet/ether.h being included in line 2248 of
libxtables/xtables.c. So maybe *also* a bug in bionic?!
Cheers, Phil
next prev parent reply other threads:[~2022-05-14 17:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 16:33 [PATCH iptables 1/2] xtables: fix compilation with musl Nick Hainke
2022-05-14 16:33 ` [PATCH iptables 2/2] xshared: " Nick Hainke
2022-05-14 17:09 ` Phil Sutter
2022-05-16 6:47 ` [PATCH] treewide: use uint* instead of u_int* vincent
2022-05-16 10:28 ` Jan Engelhardt
2022-05-16 16:16 ` vincent
2022-05-17 8:10 ` Phil Sutter
2022-05-17 8:14 ` Jan Engelhardt
2022-05-18 13:21 ` Phil Sutter
2022-05-31 21:32 ` Nick
2022-05-14 17:04 ` Phil Sutter [this message]
2022-05-14 19:14 ` [PATCH iptables 1/2] xtables: fix compilation with musl Maciej Żenczykowski
2022-05-15 12:05 ` Phil Sutter
2022-05-15 13:40 ` Maciej Żenczykowski
2022-05-17 8:17 ` Phil Sutter
2022-05-17 8:22 ` Maciej Żenczykowski
2022-05-15 14:09 ` Florian Westphal
2022-05-15 14:13 ` Maciej Żenczykowski
2022-05-17 8:14 ` Phil Sutter
2022-05-16 6:52 ` Nick
2022-05-16 7:12 ` Maciej Żenczykowski
2022-05-16 16:24 ` [PATCH] " vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn/hMODAkEEbzQno@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=maze@google.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.