From: Wolfram Sang <wsa@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-i2c@vger.kernel.org, git@xilinx.com
Subject: Re: [PATCH 3/4] i2c: xiic: Correct the datatype for rx_watermark
Date: Sat, 14 May 2022 16:04:21 +0200 [thread overview]
Message-ID: <Yn+25eC8sre9RVH9@shikoro> (raw)
In-Reply-To: <29058bda-e040-2b69-7dd1-33e52ba431c5@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On Thu, Apr 21, 2022 at 10:50:32AM +0200, Michal Simek wrote:
>
>
> On 4/20/22 09:59, Shubhrajyoti Datta wrote:
> > The message length data type should be u16 as per the i2c_msg structure
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > ---
> > drivers/i2c/busses/i2c-xiic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> > index 16a7e3164e68..eb4d34e7c0fe 100644
> > --- a/drivers/i2c/busses/i2c-xiic.c
> > +++ b/drivers/i2c/busses/i2c-xiic.c
> > @@ -576,7 +576,7 @@ static int xiic_busy(struct xiic_i2c *i2c)
> > static void xiic_start_recv(struct xiic_i2c *i2c)
> > {
> > - u8 rx_watermark;
> > + u16 rx_watermark;
> > struct i2c_msg *msg = i2c->rx_msg = i2c->tx_msg;
> > /* Clear and enable Rx full interrupt. */
>
> xiic_setreg8(struct xiic_i2c *i2c, int reg, u8 value) has u8 value it means
> I would expect you will also recast it.
> Value can't be more then IIC_RX_FIFO_DEPTH anyway that's why it shouldn't be
> a problem.
>
> xiic_setreg8(i2c, XIIC_RFD_REG_OFFSET, (u8)(rx_watermark - 1));
Waiting for v2 here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-14 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 7:59 [PATCH 0/4] i2c: xiic: misc fixes Shubhrajyoti Datta
2022-04-20 7:59 ` [PATCH 1/4] i2c-xiic: return value of xiic_reinit Shubhrajyoti Datta
2022-04-21 8:46 ` Michal Simek
2022-05-14 14:03 ` Wolfram Sang
2022-04-20 7:59 ` [PATCH 2/4] i2c: xiic: Fix coding style issues Shubhrajyoti Datta
2022-05-14 14:03 ` Wolfram Sang
2022-04-20 7:59 ` [PATCH 3/4] i2c: xiic: Correct the datatype for rx_watermark Shubhrajyoti Datta
2022-04-21 8:50 ` Michal Simek
2022-05-14 14:04 ` Wolfram Sang [this message]
2022-04-20 7:59 ` [PATCH 4/4] i2c: xiic: Fix Tx Interrupt path for grouped messages Shubhrajyoti Datta
2022-04-21 8:51 ` Michal Simek
2022-05-14 14:04 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn+25eC8sre9RVH9@shikoro \
--to=wsa@kernel.org \
--cc=git@xilinx.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.