From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DE7C433EF for ; Thu, 12 May 2022 16:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351682AbiELQPm (ORCPT ); Thu, 12 May 2022 12:15:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233278AbiELQPl (ORCPT ); Thu, 12 May 2022 12:15:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFDDF335 for ; Thu, 12 May 2022 09:15:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A051DB8290E for ; Thu, 12 May 2022 16:15:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E35C385B8; Thu, 12 May 2022 16:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652372137; bh=i70+uprLNQWZny9cy3ILuJ6vbMHaIKlCK36vJUzGZs4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sqN4NGF72oJUnGSThojIkUaS2ddM9sV7wTkF+bJHaMEOg0xmNG6gFJZBZYH7GREpm RwD4lCYTSwL1YmkAGEYrpjtGc7PG3SVskxeLrtDlar8YHDi0RAM1uf21ZIhQ3izELQ p0bh8qweZQtprn9NkA/M1U+6vl+L14tpFtBings7t54MNiGBFkqhhEL7Nst2CDgn/8 2In0MBn5uSRWZC/HcTGU4dgeKCyNBv3WpdVM0LX87hO56A+LjS5GvApWjzMir2HW5S ZvoZHocC36qfbBkbZ7/9AqD+74uf6BJSwxSR9ThWyv2XLBlGl/FrU+UwZzJRrjiAWH 2i5Ked+Ihrwtw== Date: Thu, 12 May 2022 09:15:35 -0700 From: Jaegeuk Kim To: Dan Carpenter Cc: Daeho Jeong , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() Message-ID: References: <20220512092043.GD29930@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512092043.GD29930@kadam> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 05/12, Dan Carpenter wrote: > On Wed, May 11, 2022 at 10:37:57AM -0700, Jaegeuk Kim wrote: > > Hi Dan, > > > > Thank you for the fix. If you don't mind, can I integrate this fix into > > the original patch which is in -next? > > > > Yeah, that's not a problem. Feel free. Thank you~ > > regards, > dan carpenter > > > Thanks, > > > > On 05/11, Dan Carpenter wrote: > > > Return an error code if f2fs_iget() fails. Currently it returns > > > success. > > > > > > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way") > > > Signed-off-by: Dan Carpenter > > > --- > > > fs/f2fs/file.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > index 79d1a20fbda9..cd768fadfd67 100644 > > > --- a/fs/f2fs/file.c > > > +++ b/fs/f2fs/file.c > > > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > > > pinode = f2fs_iget(inode->i_sb, fi->i_pino); > > > if (IS_ERR(pinode)) { > > > f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > + ret = PTR_ERR(pinode); > > > goto out; > > > } > > > > > > -- > > > 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D6A4C433F5 for ; Thu, 12 May 2022 16:15:51 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1npBTg-00036I-Pt; Thu, 12 May 2022 16:15:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1npBTf-000365-Hg for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 May 2022 16:15:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QBtUSt4LH2Y8JbzfUWR6/VcccOE9tYBwFef3idunsSY=; b=cfnLsw9Nry9poLbuEI7MxxBr+n WSld7FPzQSZidECe7XKQuP+1Keny3D1FWLTZOpCY7k754Ej/istWCssof11vBBNfeC+kE4669voz8 kmcaczOVsIoRBI1QFCtNcZCZeBcWWQPxsv8qkTiwGvbViN4nQGWvMo7ppJD2TpuvDc2g=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QBtUSt4LH2Y8JbzfUWR6/VcccOE9tYBwFef3idunsSY=; b=jhjnL6sut2+WtuaSXMQVoprP6A y7/NIS/a7NyhG+koxg7lCTUg6Emzr8MDEJsknxmXVcBjSFdrl+NevLQIiHkO4L17S2hfOvCCqOJ6r vdl7R49KdNHiV79uiQY1sZ4BU8il8/y0UJSaJUf3oJPLoCxz1vaT5dqV28YwE7BBzOjU=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1npBTf-009tAv-63 for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 May 2022 16:15:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82263B8289C; Thu, 12 May 2022 16:15:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E35C385B8; Thu, 12 May 2022 16:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652372137; bh=i70+uprLNQWZny9cy3ILuJ6vbMHaIKlCK36vJUzGZs4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sqN4NGF72oJUnGSThojIkUaS2ddM9sV7wTkF+bJHaMEOg0xmNG6gFJZBZYH7GREpm RwD4lCYTSwL1YmkAGEYrpjtGc7PG3SVskxeLrtDlar8YHDi0RAM1uf21ZIhQ3izELQ p0bh8qweZQtprn9NkA/M1U+6vl+L14tpFtBings7t54MNiGBFkqhhEL7Nst2CDgn/8 2In0MBn5uSRWZC/HcTGU4dgeKCyNBv3WpdVM0LX87hO56A+LjS5GvApWjzMir2HW5S ZvoZHocC36qfbBkbZ7/9AqD+74uf6BJSwxSR9ThWyv2XLBlGl/FrU+UwZzJRrjiAWH 2i5Ked+Ihrwtw== Date: Thu, 12 May 2022 09:15:35 -0700 From: Jaegeuk Kim To: Dan Carpenter Message-ID: References: <20220512092043.GD29930@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220512092043.GD29930@kadam> X-Headers-End: 1npBTf-009tAv-63 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, Daeho Jeong , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/12, Dan Carpenter wrote: > On Wed, May 11, 2022 at 10:37:57AM -0700, Jaegeuk Kim wrote: > > Hi Dan, > > > > Thank you for the fix. If you don't mind, can I integrate this fix into > > the original patch which is in -next? > > > > Yeah, that's not a problem. Feel free. Thank you~ > > regards, > dan carpenter > > > Thanks, > > > > On 05/11, Dan Carpenter wrote: > > > Return an error code if f2fs_iget() fails. Currently it returns > > > success. > > > > > > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way") > > > Signed-off-by: Dan Carpenter > > > --- > > > fs/f2fs/file.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > > index 79d1a20fbda9..cd768fadfd67 100644 > > > --- a/fs/f2fs/file.c > > > +++ b/fs/f2fs/file.c > > > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > > > pinode = f2fs_iget(inode->i_sb, fi->i_pino); > > > if (IS_ERR(pinode)) { > > > f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]); > > > + ret = PTR_ERR(pinode); > > > goto out; > > > } > > > > > > -- > > > 2.35.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel