From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] waitid10: raise SIGFPE directly
Date: Fri, 13 May 2022 11:07:40 +0200 [thread overview]
Message-ID: <Yn4f3HLBTJ/ehtyh@yuki> (raw)
In-Reply-To: <CAEemH2dV04-F1mFHiCodQV+uWMbMWxEVy3hW+iqSv6zyJwjyMg@mail.gmail.com>
Hi!
> Better to have code comments to explain the reason here,
> just for better readability.
What exactly should we comment there, something as:
Triggering SIGFPE by invalid instruction is not always possible, some
architectures does not trap division-by-zero at all and even when it's
possible we would have to fight the compiler optimizations that have
tendency to remove undefined operations.
> And vote for merging before the new release as well.
That's what I'm aiming for.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-13 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 13:10 [LTP] [PATCH v2] waitid10: raise SIGFPE directly Cyril Hrubis
2022-05-12 19:30 ` Jan Stancek
2022-05-13 2:02 ` Li Wang
2022-05-13 9:07 ` Cyril Hrubis [this message]
2022-05-13 9:24 ` Li Wang
2022-05-13 12:38 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn4f3HLBTJ/ehtyh@yuki \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.