From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6293407362814798338==" MIME-Version: 1.0 From: Joerg Roedel To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 8521/9759] drivers/iommu/mtk_iommu.c:878 mtk_iommu_mm_dts_parse() error: uninitialized symbol 'larbnode'. Date: Fri, 13 May 2022 15:30:17 +0200 Message-ID: In-Reply-To: <202205070247.0InKO8AP-lkp@intel.com> List-Id: --===============6293407362814798338== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, May 09, 2022 at 12:26:31PM +0300, Dan Carpenter wrote: > d2e9a1102cfc22 Yong Wu 2022-05-03 834 static int mtk_iommu_mm_dts_parse= (struct device *dev, struct component_match **match, > d2e9a1102cfc22 Yong Wu 2022-05-03 835 struct mtk_iommu_data *data) > 0df4fabe208d95 Yong Wu 2016-02-23 836 { > baf94e6ebff962 Yong Wu 2021-01-11 837 struct device_node *larbnode, *s= micomm_node; > baf94e6ebff962 Yong Wu 2021-01-11 838 struct platform_device *plarbdev; > baf94e6ebff962 Yong Wu 2021-01-11 839 struct device_link *link; > d2e9a1102cfc22 Yong Wu 2022-05-03 840 int i, larb_nr, ret; > d2e9a1102cfc22 Yong Wu 2022-05-03 841 = > d2e9a1102cfc22 Yong Wu 2022-05-03 842 larb_nr =3D of_count_phandle_wit= h_args(dev->of_node, "mediatek,larbs", NULL); > d2e9a1102cfc22 Yong Wu 2022-05-03 843 if (larb_nr < 0) > d2e9a1102cfc22 Yong Wu 2022-05-03 844 return larb_nr; > d2e9a1102cfc22 Yong Wu 2022-05-03 845 = > d2e9a1102cfc22 Yong Wu 2022-05-03 846 for (i =3D 0; i < larb_nr; i++) { > = > Smatch can't parse of data so it doesn't know that larb_nr can't be > zero. Hmm, could larb_nr be zero with a broken/malicous device tree? -- = J=C3=B6rg R=C3=B6del jroedel(a)suse.de SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 N=C3=BCrnberg Germany = (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Ivo Totev --===============6293407362814798338==--