From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH net-next 1/2] net: phy: micrel: Allow probing without .driver_data
Date: Fri, 13 May 2022 21:36:57 +0200 [thread overview]
Message-ID: <Yn6zWVRztEwibCy/@lunn.ch> (raw)
In-Reply-To: <20220513114613.762810-1-festevam@gmail.com>
On Fri, May 13, 2022 at 08:46:12AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Currently, if the .probe element is present in the phy_driver structure
> and the .driver_data is not, a NULL pointer dereference happens.
>
> Allow passing .probe without .driver_data by inserting NULL checks
> for priv->type.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-05-13 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 11:46 [PATCH net-next 1/2] net: phy: micrel: Allow probing without .driver_data Fabio Estevam
2022-05-13 11:46 ` [PATCH net-next 2/2] net: phy: micrel: Use the kszphy probe/suspend/resume Fabio Estevam
2022-05-13 19:37 ` Andrew Lunn
2022-05-13 19:36 ` Andrew Lunn [this message]
2022-05-16 20:10 ` [PATCH net-next 1/2] net: phy: micrel: Allow probing without .driver_data patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn6zWVRztEwibCy/@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.