From: Andrew Lunn <andrew@lunn.ch>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT
Date: Mon, 2 May 2022 20:37:58 +0200 [thread overview]
Message-ID: <YnAlBvWyyJ9oDcpz@lunn.ch> (raw)
In-Reply-To: <20220430124803.1165005-1-mnhagan88@gmail.com>
> + if (!memcmp(id.base.vendor_name, "HUAWEI ", 16) &&
> + !memcmp(id.base.vendor_pn, "MA5671A ", 16))
> + sfp->tx_fault_ignore = true;
> + else
> + sfp->tx_fault_ignore = false;
> +
> + return 0;
> +
> return 0;
Why do we need two return 0; Probably a merged conflict gone wrong.
Andrew
next prev parent reply other threads:[~2022-05-02 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 12:48 [PATCH] net: sfp: Add tx-fault quirk for Huawei MA5671A SFP ONT Matthew Hagan
2022-05-02 18:37 ` Andrew Lunn [this message]
2022-05-02 22:32 ` Matthew Hagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnAlBvWyyJ9oDcpz@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mnhagan88@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.