From: Rob Herring <robh@kernel.org>
To: Nathan Rossi <nathan@nathanrossi.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: dsa: marvell: Add single-chip-address property
Date: Mon, 2 May 2022 17:32:51 -0500 [thread overview]
Message-ID: <YnBcE96wbQxZguw2@robh.at.kernel.org> (raw)
In-Reply-To: <20220423131427.237160-1-nathan@nathanrossi.com>
On Sat, Apr 23, 2022 at 01:14:27PM +0000, Nathan Rossi wrote:
> Some Marvell DSA devices can be accessed in a single chip addressing
> mode. This is currently configured by setting the address of the switch
> to 0. However switches in this configuration do not respond to address
> 0, only responding to higher addresses (fixed addressed based on the
> switch model) for the individual ports/etc. This is a feature to allow
> for other phys to exist on the same mdio bus.
>
> This change defines a 'single-chip-address' property in order to
> explicitly define that the chip is accessed in this mode. This allows
> for a switch to have an address defined other than 0, so that address
> 0 can be used for another mdio device.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> Documentation/devicetree/bindings/net/dsa/marvell.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> index 2363b41241..5c7304274c 100644
> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> @@ -46,6 +46,8 @@ Optional properties:
> - mdio? : Container of PHYs and devices on the external MDIO
> bus. The node must contains a compatible string of
> "marvell,mv88e6xxx-mdio-external"
> +- single-chip-address : Device is configured to use single chip addressing
> + mode.
Doesn't sound like a common feature, it needs a vendor prefix.
Some of the commit message explanation of what 'single chip addressing'
is is needed here.
Rob
prev parent reply other threads:[~2022-05-02 22:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 13:14 [PATCH 1/2] dt-bindings: net: dsa: marvell: Add single-chip-address property Nathan Rossi
2022-04-23 13:14 ` [PATCH 2/2] net: dsa: mv88e6xxx: Handle single-chip-address OF property Nathan Rossi
2022-04-23 14:07 ` Andrew Lunn
2022-04-23 14:41 ` Nathan Rossi
2022-04-23 15:16 ` Marek Behún
2022-04-23 15:18 ` Marek Behún
2022-04-23 15:41 ` Andrew Lunn
2022-04-24 12:57 ` Nathan Rossi
2022-05-02 22:32 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnBcE96wbQxZguw2@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@nathanrossi.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.