From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: <frederic.konrad@xilinx.com>
Cc: <qemu-devel@nongnu.org>, <alistair@alistair23.me>,
<edgar.iglesias@gmail.com>, <peter.maydell@linaro.org>,
<qemu-arm@nongnu.org>, <sai.pavan.boddu@xilinx.com>,
<edgari@xilinx.com>, <fkonrad@amd.com>
Subject: Re: [PATCH v1 4/4] xlnx-zynqmp: fix the irq mapping for the display port and its dma
Date: Tue, 3 May 2022 18:00:03 +0200 [thread overview]
Message-ID: <YnFRg1V/uo9MPHDY@toto> (raw)
In-Reply-To: <20220503152545.1100386-5-fkonrad@xilinx.com>
On Tue, May 03, 2022 at 04:25:45PM +0100, frederic.konrad@xilinx.com wrote:
> From: Frederic Konrad <fkonrad@amd.com>
>
> When the display port has been initially implemented the device driver wasn't
> using interrupts. Now that the display port driver waits for vblank interrupt
> it has been noticed that the irq mapping is wrong. So use the value from the
> linux device tree and the ultrascale+ reference manual.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
>
> Signed-off-by: Frederic Konrad <fkonrad@amd.com>
> ---
> hw/arm/xlnx-zynqmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index 375309e68e..383e177a00 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -60,10 +60,10 @@
> #define SERDES_SIZE 0x20000
>
> #define DP_ADDR 0xfd4a0000
> -#define DP_IRQ 113
> +#define DP_IRQ 0x77
>
> #define DPDMA_ADDR 0xfd4c0000
> -#define DPDMA_IRQ 116
> +#define DPDMA_IRQ 0x7a
>
> #define APU_ADDR 0xfd5c0000
> #define APU_IRQ 153
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-05-03 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 15:25 [PATCH v1 0/4] xlnx-zcu102: fix the display port frederic.konrad
2022-05-03 15:25 ` [PATCH v1 1/4] xlnx_dp: fix the wrong register size frederic.konrad
2022-05-03 15:58 ` Edgar E. Iglesias
2022-05-03 15:25 ` [PATCH v1 2/4] xlnx_dp: Introduce a vblank signal frederic.konrad
2022-05-03 15:59 ` Edgar E. Iglesias
2022-05-16 9:56 ` Peter Maydell
2022-05-16 10:36 ` Frederic Konrad
2022-05-16 10:42 ` Peter Maydell
2022-05-03 15:25 ` [PATCH v1 3/4] xlnx_dp: Fix the interrupt disable logic frederic.konrad
2022-05-03 15:25 ` [PATCH v1 4/4] xlnx-zynqmp: fix the irq mapping for the display port and its dma frederic.konrad
2022-05-03 16:00 ` Edgar E. Iglesias [this message]
2022-05-13 14:42 ` [PATCH v1 0/4] xlnx-zcu102: fix the display port Frederic Konrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnFRg1V/uo9MPHDY@toto \
--to=edgar.iglesias@xilinx.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=edgari@xilinx.com \
--cc=fkonrad@amd.com \
--cc=frederic.konrad@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.