From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: kbuild-all@lists.01.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_s2idle_bug can be static
Date: Wed, 4 May 2022 02:21:00 +0800 [thread overview]
Message-ID: <YnFyjKyfnPnfpHgW@74ccfaeec2ea> (raw)
In-Reply-To: <202205040241.QemV1sMH-lkp@intel.com>
drivers/platform/x86/thinkpad_acpi.c:322:20: warning: symbol 'quirk_s2idle_bug' was not declared. Should it be static?
Fixes: a50dfa903391 ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of laptops")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index f385450af8647..d5431d3d4246f 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -319,7 +319,7 @@ struct quirk_entry quirk_btusb_bug = {
.btusb_bug = true,
};
-struct quirk_entry quirk_s2idle_bug = {
+static struct quirk_entry quirk_s2idle_bug = {
.s2idle_bug_mmio = 0xfed80380,
};
next prev parent reply other threads:[~2022-05-03 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 18:24 [pdx86-platform-drivers-x86:review-hans 31/32] drivers/platform/x86/thinkpad_acpi.c:322:20: sparse: sparse: symbol 'quirk_s2idle_bug' was not declared. Should it be static? kernel test robot
2022-05-03 18:21 ` kernel test robot [this message]
2022-05-06 10:09 ` [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_s2idle_bug can be static Hans de Goede
2022-05-06 10:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnFyjKyfnPnfpHgW@74ccfaeec2ea \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.