From: Alexey Dobriyan <adobriyan@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org
Subject: Re: [PATCH] module: fix [e_shstrndx].sh_size=0 OOB access
Date: Wed, 4 May 2022 12:50:43 +0300 [thread overview]
Message-ID: <YnJMcyhF5bv4IJAq@localhost.localdomain> (raw)
In-Reply-To: <YnGNSNcUbkwLNWNd@bombadil.infradead.org>
On Tue, May 03, 2022 at 01:15:04PM -0700, Luis Chamberlain wrote:
> On Tue, May 03, 2022 at 05:57:59PM +0300, Alexey Dobriyan wrote:
> > It is trivial to craft a module to trigger OOB access in this line:
> >
> > if (info->secstrings[strhdr->sh_size - 1] != '\0') {
> >
> > BUG: unable to handle page fault for address: ffffc90000aa0fff
> > #PF: supervisor read access in kernel mode
> > #PF: error_code(0x0000) - not-present page
> > PGD 100000067 P4D 100000067 PUD 100066067 PMD 10436f067 PTE 0
> > Oops: 0000 [#1] PREEMPT SMP PTI
> > CPU: 7 PID: 1215 Comm: insmod Not tainted 5.18.0-rc5-00007-g9bf578647087-dirty #10
> > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-4.fc34 04/01/2014
> > RIP: 0010:load_module+0x19b/0x2391
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> Thanks! Can you resend and Cc stable?
Stable will pick it up simply because patch does apply I assume?
> This seems like an issue present for
> a long time, can you identify the commit which introduced the issue?
I thought it was ancient code but no.
next prev parent reply other threads:[~2022-05-04 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 14:57 [PATCH] module: fix [e_shstrndx].sh_size=0 OOB access Alexey Dobriyan
2022-05-03 20:15 ` Luis Chamberlain
2022-05-04 9:50 ` Alexey Dobriyan [this message]
2022-05-04 9:54 ` [PATCH v2] " Alexey Dobriyan
2022-05-04 20:30 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnJMcyhF5bv4IJAq@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.