From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABF77C433FE for ; Thu, 5 May 2022 07:13:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-116-AxjGHKfaNPeZ-2BtekO4LA-1; Thu, 05 May 2022 03:13:19 -0400 X-MC-Unique: AxjGHKfaNPeZ-2BtekO4LA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1420038041DA; Thu, 5 May 2022 07:13:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3A21463EC0; Thu, 5 May 2022 07:13:15 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3BCD01947BB2; Thu, 5 May 2022 07:13:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D59171947040 for ; Wed, 4 May 2022 09:57:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id AFAB89E89; Wed, 4 May 2022 09:57:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAF359E8E for ; Wed, 4 May 2022 09:57:39 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCE06185A7A4 for ; Wed, 4 May 2022 09:57:39 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-ZJMTbsidNWuvaIdEM2BSyA-1; Wed, 04 May 2022 05:57:36 -0400 X-MC-Unique: ZJMTbsidNWuvaIdEM2BSyA-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2AE6561A5A; Wed, 4 May 2022 09:57:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F749C385A5; Wed, 4 May 2022 09:57:33 +0000 (UTC) Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id ebcdca06 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 4 May 2022 09:57:31 +0000 (UTC) Date: Wed, 4 May 2022 11:57:29 +0200 From: "Jason A. Donenfeld" To: Stafford Horne Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mailman-Approved-At: Thu, 05 May 2022 07:13:10 +0000 Subject: Re: [dm-devel] [PATCH v2] hex2bin: make the function hex_to_bin constant-time X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Shevchenko , Mike Snitzer , Herbert Xu , Linux Kernel Mailing List , Mimi Zohar , Milan Broz , device-mapper development , Mikulas Patocka , Linux Crypto Mailing List , Linus Torvalds , "David S. Miller" Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 04, 2022 at 11:42:27AM +0200, Jason A. Donenfeld wrote: > So more likely is that this patch just helps unmask a real issue > elsewhere -- linker, compiler, or register restoration after preemption. > I don't think there's anything to do with regards to the patch of this > thread, as it's clearly fine. The problem even goes away if I just add a nop... diff --git a/lib/hexdump.c b/lib/hexdump.c index 06833d404398..ace74f9b3d5a 100644 --- a/lib/hexdump.c +++ b/lib/hexdump.c @@ -46,6 +46,7 @@ EXPORT_SYMBOL(hex_asc_upper); int hex_to_bin(unsigned char ch) { unsigned char cu = ch & 0xdf; + __asm__("l.nop 0"); return -1 + ((ch - '0' + 1) & (unsigned)((ch - '9' - 1) & ('0' - 1 - ch)) >> 8) + ((cu - 'A' + 11) & (unsigned)((cu - 'F' - 1) & ('A' - 1 - cu)) >> 8); -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185C8C433F5 for ; Wed, 4 May 2022 09:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347607AbiEDKBL (ORCPT ); Wed, 4 May 2022 06:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232653AbiEDKBK (ORCPT ); Wed, 4 May 2022 06:01:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9261426AFB; Wed, 4 May 2022 02:57:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3625E61A95; Wed, 4 May 2022 09:57:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F749C385A5; Wed, 4 May 2022 09:57:33 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="LgiOdaZg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1651658252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QxTQmRrU2TPE1t9O7hHsX1uS6rLbGna3bwCr6dOHKs=; b=LgiOdaZgjat5AfzZ+JngxczZs4gg59ImR+qNyDKmwNLroONljXjLYnSgEmdveQcEw2eBOM T3mCyB6rnxs4w/diOMepTIbhU25q5no41388p6Hx6UWUNz6a8ifQ3kKTHUONn7+2u3VRIx mrfhEjCpmlNf0MfkShTqF8vlmqkMFlA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id ebcdca06 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 4 May 2022 09:57:31 +0000 (UTC) Date: Wed, 4 May 2022 11:57:29 +0200 From: "Jason A. Donenfeld" To: Stafford Horne Cc: Mikulas Patocka , Linus Torvalds , Andy Shevchenko , device-mapper development , Linux Kernel Mailing List , Linux Crypto Mailing List , Herbert Xu , "David S. Miller" , Mike Snitzer , Mimi Zohar , Milan Broz Subject: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, May 04, 2022 at 11:42:27AM +0200, Jason A. Donenfeld wrote: > So more likely is that this patch just helps unmask a real issue > elsewhere -- linker, compiler, or register restoration after preemption. > I don't think there's anything to do with regards to the patch of this > thread, as it's clearly fine. The problem even goes away if I just add a nop... diff --git a/lib/hexdump.c b/lib/hexdump.c index 06833d404398..ace74f9b3d5a 100644 --- a/lib/hexdump.c +++ b/lib/hexdump.c @@ -46,6 +46,7 @@ EXPORT_SYMBOL(hex_asc_upper); int hex_to_bin(unsigned char ch) { unsigned char cu = ch & 0xdf; + __asm__("l.nop 0"); return -1 + ((ch - '0' + 1) & (unsigned)((ch - '9' - 1) & ('0' - 1 - ch)) >> 8) + ((cu - 'A' + 11) & (unsigned)((cu - 'F' - 1) & ('A' - 1 - cu)) >> 8);