From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko Oshino <yuiko.oshino@microchip.com>
Cc: woojung.huh@microchip.com, davem@davemloft.net,
netdev@vger.kernel.org, ravi.hegde@microchip.com,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask.
Date: Wed, 4 May 2022 23:41:49 +0200 [thread overview]
Message-ID: <YnLzHfeo6dyULtbs@lunn.ch> (raw)
In-Reply-To: <20220504152822.11890-2-yuiko.oshino@microchip.com>
On Wed, May 04, 2022 at 08:28:21AM -0700, Yuiko Oshino wrote:
> update LAN88xx phy ID and phy ID mask because the existing code conflicts with the LAN8742 phy.
>
> The current phy IDs on the available hardware.
> LAN8742 0x0007C130, 0x0007C131
> LAN88xx 0x0007C132
>
> Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
> static struct phy_driver microchip_phy_driver[] = {
> {
> - .phy_id = 0x0007c130,
> - .phy_id_mask = 0xfffffff0,
> + .phy_id = 0x0007c132,
> + /* This mask (0xfffffff2) is to differentiate from
> + * LAN8742 (phy_id 0x0007c130 and 0x0007c131)
> + * and allows future phy_id revisions.
> + */
> + .phy_id_mask = 0xfffffff2,
It is odd, but you should be able to change your mind later if the
hardware engineers don't actually stick to this odd scheme.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-05-04 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 15:28 [PATCH v3 net-next 0/2] net: phy: add LAN8742 phy support Yuiko Oshino
2022-05-04 15:28 ` [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask Yuiko Oshino
2022-05-04 21:41 ` Andrew Lunn [this message]
2022-05-04 15:28 ` [PATCH v3 net-next 2/2] net: phy: smsc: add LAN8742 phy support Yuiko Oshino
2022-05-04 21:45 ` Andrew Lunn
2022-05-05 0:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnLzHfeo6dyULtbs@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ravi.hegde@microchip.com \
--cc=woojung.huh@microchip.com \
--cc=yuiko.oshino@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.