diff for duplicates of <YnNkgfnHlUTky0lt@MiWiFi-R3L-srv> diff --git a/a/1.txt b/N1/1.txt index 9dff259..92f7589 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,19 +8,19 @@ On 04/28/22 at 10:48am, Sourabh Jain wrote: > > > > > > +#if defined(CONFIG_MEMORY_HOTPLUG) > > > > > > +static int crash_memhp_notifier(struct notifier_block *nb, -> > > > > > +??? unsigned long val, void *v) +> > > > > > + unsigned long val, void *v) > > > > > > +{ -> > > > > > +??? struct memory_notify *mhp = v; +> > > > > > + struct memory_notify *mhp = v; > > > > > > + -> > > > > > +??? switch (val) { -> > > > > > +??? case MEM_ONLINE: -> > > > > > +??????? crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, -1U); +> > > > > > + switch (val) { +> > > > > > + case MEM_ONLINE: +> > > > > > + crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, -1U); > > > > > We don't differentiate the memory add/remove, cpu add, except of cpu > > > > > remove. Means the hp_action only differentiate cpu remove from the other > > > > > action. Maybe only making two types? > > > > > -> > > > > #define KEXEC_CRASH_HP_REMOVE_CPU?? 0 -> > > > > #define KEXEC_CRASH_HP_UPDATE_OTHER????? 1 +> > > > > #define KEXEC_CRASH_HP_REMOVE_CPU 0 +> > > > > #define KEXEC_CRASH_HP_UPDATE_OTHER 1 > > > > > > > > > Sourabh Jain's work with PPC uses REMOVE_CPU, REMOVE_MEMORY, and > > > > ADD_MEMORY. diff --git a/a/content_digest b/N1/content_digest index 82627da..99a2b89 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,9 +6,29 @@ "ref\0YmeBjrChOHsIYG3e@MiWiFi-R3L-srv\0" "ref\0f2dbd4fe-6201-b5c4-2725-dec9c3dbf13e@linux.ibm.com\0" "From\0Baoquan He <bhe@redhat.com>\0" - "Subject\0[PATCH v7 4/8] crash: add generic infrastructure for crash hotplug support\0" + "Subject\0Re: [PATCH v7 4/8] crash: add generic infrastructure for crash hotplug support\0" "Date\0Thu, 5 May 2022 13:45:37 +0800\0" - "To\0kexec@lists.infradead.org\0" + "To\0Sourabh Jain <sourabhjain@linux.ibm.com>\0" + "Cc\0Eric DeVolder <eric.devolder@oracle.com>" + linux-kernel@vger.kernel.org + x86@kernel.org + kexec@lists.infradead.org + ebiederm@xmission.com + dyoung@redhat.com + vgoyal@redhat.com + tglx@linutronix.de + mingo@redhat.com + bp@alien8.de + dave.hansen@linux.intel.com + hpa@zytor.com + nramas@linux.microsoft.com + thomas.lendacky@amd.com + robh@kernel.org + efault@gmx.de + rppt@kernel.org + david@redhat.com + konrad.wilk@oracle.com + " boris.ostrovsky@oracle.com\0" "\00:1\0" "b\0" "On 04/28/22 at 10:48am, Sourabh Jain wrote:\n" @@ -21,19 +41,19 @@ "\n" "> > > > > > +#if defined(CONFIG_MEMORY_HOTPLUG)\n" "> > > > > > +static int crash_memhp_notifier(struct notifier_block *nb,\n" - "> > > > > > +??? unsigned long val, void *v)\n" + "> > > > > > +\302\240\302\240\302\240 unsigned long val, void *v)\n" "> > > > > > +{\n" - "> > > > > > +??? struct memory_notify *mhp = v;\n" + "> > > > > > +\302\240\302\240\302\240 struct memory_notify *mhp = v;\n" "> > > > > > +\n" - "> > > > > > +??? switch (val) {\n" - "> > > > > > +??? case MEM_ONLINE:\n" - "> > > > > > +??????? crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, -1U);\n" + "> > > > > > +\302\240\302\240\302\240 switch (val) {\n" + "> > > > > > +\302\240\302\240\302\240 case MEM_ONLINE:\n" + "> > > > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY, -1U);\n" "> > > > > We don't differentiate the memory add/remove, cpu add, except of cpu\n" "> > > > > remove. Means the hp_action only differentiate cpu remove from the other\n" "> > > > > action. Maybe only making two types?\n" "> > > > > \n" - "> > > > > #define KEXEC_CRASH_HP_REMOVE_CPU?? 0\n" - "> > > > > #define KEXEC_CRASH_HP_UPDATE_OTHER????? 1\n" + "> > > > > #define KEXEC_CRASH_HP_REMOVE_CPU\302\240\302\240 0\n" + "> > > > > #define KEXEC_CRASH_HP_UPDATE_OTHER\302\240\302\240\302\240\302\240\302\240 1\n" "> > > > > \n" "> > > > Sourabh Jain's work with PPC uses REMOVE_CPU, REMOVE_MEMORY, and\n" "> > > > ADD_MEMORY.\n" @@ -92,4 +112,4 @@ "> Sourabh Jain\n" > -09350633c12bacb8a8de81a3aa8b2757ed745938e1c3660344f05b2ecf73ab51 +2d5fd02c2c804849f89d6592d931dbf79c77666427f38e5617f408a3e7824fd6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.