From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D924BC433F5 for ; Thu, 5 May 2022 12:17:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376459AbiEEMVX (ORCPT ); Thu, 5 May 2022 08:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355567AbiEEMVW (ORCPT ); Thu, 5 May 2022 08:21:22 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DD1E54FB5; Thu, 5 May 2022 05:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=aZq5jO8c2cQjpNu/6cSRu86328iJHgS0Kgbi++2VnQk=; b=t9 rEggc8JstJI8HquYLGPX7K2BbrWG3xtlnbc5OBWAZzd6tAddeHR6S3uzlGNzNnpsgY73ujkYD4fd/ uo1KRNTnmkYJPUMERaGHOKvsAIS299g2tf1xHtD5/TV7sqtYzry9CVbxv8trMehsTnNzawMVoo4je TzI5G6zMq8PYzt4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nmaPw-001LnC-7I; Thu, 05 May 2022 14:17:12 +0200 Date: Thu, 5 May 2022 14:17:12 +0200 From: Andrew Lunn To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Vivien Didelot , Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds Message-ID: References: <20220503153613.15320-1-zajec5@gmail.com> <235aa025-7c12-f7e1-d788-9a2ef97f664f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <235aa025-7c12-f7e1-d788-9a2ef97f664f@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 05, 2022 at 07:19:41AM +0200, Rafał Miłecki wrote: > On 3.05.2022 17:36, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > This allows specifying multiple Ethernet speeds in a single DT uint32 > > value. > > > > Signed-off-by: Rafał Miłecki > > Ansuel please check if my patchset conflicts in any way with your work. > > Andrew suggested to combine both but right now I don't see it as > necessary. > > I'd still appreciate your review of my work. Such binding may be > required for some hardware controlled LEDs setup too I guess. Please look at the LED binding. It is an LED you are trying to control, so that is the binding you should be using. How do you describe this functionality using that binding. Ansuel code will give you the framework to actually do the implementation within. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58AE8C433EF for ; Thu, 5 May 2022 12:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JZCyEgdTTp8sibOxQoqxQc5ByxFXdNimYeQw1YMMoF8=; b=c3Gh00ZGeobeih v6Xzr/wV1n5GmOD3dD+XRqHZ3vRxClKoPsWE/D925YCIc161tdkMCrpC8x3k9OLBt6LhwNun2qEGQ IxMxcxeGb94c4PEgM6AiL/C/zmJ9K+ogVhwYtIqDehLeKr4cCVJiZWgqfZEDeYSY/+A72MLPN6/Kv AwVqNYUXVVTZw99MF2SXyYAl21lCYAdTWYeXvXtBM6f1ZFcJa9kQl5VioI0D84S8l3CuEaF+VjgN4 YWqvRkUI+NAkjhdOOPKYe8YZWSsfTPlxZ2VhC9WXugJLTnlJYuvmfXmImMAhwxswoXcb5d3YyKcQ/ 9JJe7GisFFZ5x5GuZNcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmaQJ-00FlYJ-Ql; Thu, 05 May 2022 12:17:35 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmaQH-00FlWz-6c for linux-arm-kernel@lists.infradead.org; Thu, 05 May 2022 12:17:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=aZq5jO8c2cQjpNu/6cSRu86328iJHgS0Kgbi++2VnQk=; b=t9 rEggc8JstJI8HquYLGPX7K2BbrWG3xtlnbc5OBWAZzd6tAddeHR6S3uzlGNzNnpsgY73ujkYD4fd/ uo1KRNTnmkYJPUMERaGHOKvsAIS299g2tf1xHtD5/TV7sqtYzry9CVbxv8trMehsTnNzawMVoo4je TzI5G6zMq8PYzt4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nmaPw-001LnC-7I; Thu, 05 May 2022 14:17:12 +0200 Date: Thu, 5 May 2022 14:17:12 +0200 From: Andrew Lunn To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , Krzysztof Kozlowski , Pavel Machek , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Florian Fainelli , Hauke Mehrtens , Jacek Anaszewski , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Vivien Didelot , Vladimir Oltean , Jonathan Corbet , John Crispin , linux-doc@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds Message-ID: References: <20220503153613.15320-1-zajec5@gmail.com> <235aa025-7c12-f7e1-d788-9a2ef97f664f@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <235aa025-7c12-f7e1-d788-9a2ef97f664f@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220505_051733_277125_876597BC X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMDUsIDIwMjIgYXQgMDc6MTk6NDFBTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IE9uIDMuMDUuMjAyMiAxNzozNiwgUmFmYcWCIE1pxYJlY2tpIHdyb3RlOgo+ID4g RnJvbTogUmFmYcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+ID4gCj4gPiBUaGlzIGFs bG93cyBzcGVjaWZ5aW5nIG11bHRpcGxlIEV0aGVybmV0IHNwZWVkcyBpbiBhIHNpbmdsZSBEVCB1 aW50MzIKPiA+IHZhbHVlLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kg PHJhZmFsQG1pbGVja2kucGw+Cj4gCj4gQW5zdWVsIHBsZWFzZSBjaGVjayBpZiBteSBwYXRjaHNl dCBjb25mbGljdHMgaW4gYW55IHdheSB3aXRoIHlvdXIgd29yay4KPiAKPiBBbmRyZXcgc3VnZ2Vz dGVkIHRvIGNvbWJpbmUgYm90aCBidXQgcmlnaHQgbm93IEkgZG9uJ3Qgc2VlIGl0IGFzCj4gbmVj ZXNzYXJ5Lgo+IAo+IEknZCBzdGlsbCBhcHByZWNpYXRlIHlvdXIgcmV2aWV3IG9mIG15IHdvcmsu IFN1Y2ggYmluZGluZyBtYXkgYmUKPiByZXF1aXJlZCBmb3Igc29tZSBoYXJkd2FyZSBjb250cm9s bGVkIExFRHMgc2V0dXAgdG9vIEkgZ3Vlc3MuCgpQbGVhc2UgbG9vayBhdCB0aGUgTEVEIGJpbmRp bmcuIEl0IGlzIGFuIExFRCB5b3UgYXJlIHRyeWluZyB0bwpjb250cm9sLCBzbyB0aGF0IGlzIHRo ZSBiaW5kaW5nIHlvdSBzaG91bGQgYmUgdXNpbmcuICBIb3cgZG8geW91CmRlc2NyaWJlIHRoaXMg ZnVuY3Rpb25hbGl0eSB1c2luZyB0aGF0IGJpbmRpbmcuIEFuc3VlbCBjb2RlIHdpbGwgZ2l2ZQp5 b3UgdGhlIGZyYW1ld29yayB0byBhY3R1YWxseSBkbyB0aGUgaW1wbGVtZW50YXRpb24gd2l0aGlu LgoKICAgIEFuZHJldwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=