From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, alexander.duyck@gmail.com,
stephen@networkplumber.org, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net, chris.snook@gmail.com,
dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com,
somnath.kotur@broadcom.com, qiangqing.zhang@nxp.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
sebastian.hesselbarth@gmail.com, thomas.petazzoni@bootlin.com,
mw@semihalf.com, linux@armlinux.org.uk, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com,
hkallweit1@gmail.com, ecree.xilinx@gmail.com,
habetsm.xilinx@gmail.com, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
wei.liu@kernel.org, decui@microsoft.com,
woojung.huh@microchip.com, wintera@linux.ibm.com,
roopa@nvidia.com, razor@blackwall.org, cai.huoqing@linux.dev,
fei.qin@corigine.com, niklas.soderlund@corigine.com,
yinjun.zhang@corigine.com, marcinguy@gmail.com,
jesionowskigreg@gmail.com, jannh@google.com,
hayeswang@realtek.com
Subject: Re: [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit
Date: Fri, 6 May 2022 20:30:03 +0900 [thread overview]
Message-ID: <YnUGuxF7lLlfDa2Y@corigine.com> (raw)
In-Reply-To: <20220506025134.794537-4-kuba@kernel.org>
On Thu, May 05, 2022 at 07:51:33PM -0700, Jakub Kicinski wrote:
> Drivers should call the TSO setting helper, GSO is controllable
> by user space.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
NFP portion:
Reviewed-by: Simon Horman <simon.horman@corigine.com>
...
> ---
> drivers/net/bonding/bond_main.c | 12 ++++++------
> drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +-
> drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
> drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +-
> drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
> drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +-
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 2 +-
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 +-
> drivers/net/ethernet/realtek/r8169_main.c | 8 ++++----
> drivers/net/ethernet/sfc/ef100_nic.c | 9 ++++++---
> drivers/net/ethernet/sfc/efx.c | 2 +-
> drivers/net/ethernet/sfc/falcon/efx.c | 2 +-
> drivers/net/hyperv/rndis_filter.c | 2 +-
> drivers/net/usb/aqc111.c | 2 +-
> drivers/net/usb/ax88179_178a.c | 2 +-
> drivers/net/usb/lan78xx.c | 2 +-
> drivers/net/usb/r8152.c | 2 +-
> drivers/s390/net/qeth_l2_main.c | 2 +-
> drivers/s390/net/qeth_l3_main.c | 2 +-
> net/bridge/br_if.c | 12 ++++++------
> net/core/dev.c | 4 ++--
> 28 files changed, 49 insertions(+), 46 deletions(-)
...
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 5528d12d1f48..c60ead337d06 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -2320,7 +2320,7 @@ static void nfp_net_netdev_init(struct nfp_net *nn)
> netdev->min_mtu = ETH_MIN_MTU;
> netdev->max_mtu = nn->max_mtu;
>
> - netif_set_gso_max_segs(netdev, NFP_NET_LSO_MAX_SEGS);
> + netif_set_tso_max_segs(netdev, NFP_NET_LSO_MAX_SEGS);
>
> netif_carrier_off(netdev);
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index 790e1d5e4b4a..75b5018f2e1b 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -380,7 +380,7 @@ int nfp_repr_init(struct nfp_app *app, struct net_device *netdev,
>
> /* Advertise but disable TSO by default. */
> netdev->features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
> - netif_set_gso_max_segs(netdev, NFP_NET_LSO_MAX_SEGS);
> + netif_set_tso_max_segs(netdev, NFP_NET_LSO_MAX_SEGS);
>
> netdev->priv_flags |= IFF_NO_QUEUE | IFF_DISABLE_NETPOLL;
> netdev->features |= NETIF_F_LLTX;
next prev parent reply other threads:[~2022-05-06 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 2:51 [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Jakub Kicinski
2022-05-06 2:51 ` [PATCH net-next 1/4] net: add netif_inherit_tso_max() Jakub Kicinski
2022-05-06 11:27 ` Simon Horman
2022-05-06 2:51 ` [PATCH net-next 2/4] net: don't allow user space to lift the device limits Jakub Kicinski
2022-05-06 2:51 ` [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit Jakub Kicinski
2022-05-06 11:30 ` Simon Horman [this message]
2022-05-09 14:31 ` Marcin Wojtas
2022-05-06 2:51 ` [PATCH net-next 4/4] net: move netif_set_gso_max helpers Jakub Kicinski
2022-05-06 2:58 ` [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Eric Dumazet
2022-05-06 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnUGuxF7lLlfDa2Y@corigine.com \
--to=simon.horman@corigine.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alexander.duyck@gmail.com \
--cc=andy@greyhouse.net \
--cc=anthony.l.nguyen@intel.com \
--cc=cai.huoqing@linux.dev \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=decui@microsoft.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=fei.qin@corigine.com \
--cc=fmanlunas@marvell.com \
--cc=gakula@marvell.com \
--cc=habetsm.xilinx@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=hayeswang@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=hkelam@marvell.com \
--cc=j.vosburgh@gmail.com \
--cc=jannh@google.com \
--cc=jesionowskigreg@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux@armlinux.org.uk \
--cc=marcinguy@gmail.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@corigine.com \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sburla@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sgoutham@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfalico@gmail.com \
--cc=wei.liu@kernel.org \
--cc=wintera@linux.ibm.com \
--cc=woojung.huh@microchip.com \
--cc=yinjun.zhang@corigine.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.