From: Ian Cowan <ian@linux.cowan.aero>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: acpi: clean up spaces to be consistent
Date: Fri, 6 May 2022 16:48:49 -0400 [thread overview]
Message-ID: <YnWJsS8OaCJssz89@fedora> (raw)
In-Reply-To: <CAJZ5v0hb9Goj9N+VCfAB9Fy+HA7EqG=Z+XJo1t53KcmF62-PbA@mail.gmail.com>
On Fri, May 06, 2022 at 08:34:09PM +0200, Rafael J. Wysocki wrote:
> On Mon, Apr 25, 2022 at 4:14 AM Ian Cowan <ian@linux.cowan.aero> wrote:
> > @@ -190,12 +190,14 @@ static int acpi_ac_battery_notify(struct notifier_block *nb,
> > static int __init thinkpad_e530_quirk(const struct dmi_system_id *d)
> > {
> > ac_sleep_before_get_state_ms = 1000;
> > +
> > return 0;
> > }
> >
> > static int __init ac_only_quirk(const struct dmi_system_id *d)
> > {
> > ac_only = 1;
> > +
> > return 0;
> > }
>
> I don't really think that it is useful to add empty lines in the two
> cases above.
>
> The rest of the patch is fine with me.
>
I just submitted v2 removing these 2 changes and leaving the others.
Thanks!
Ian
prev parent reply other threads:[~2022-05-06 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 2:14 [PATCH] drivers: acpi: clean up spaces to be consistent Ian Cowan
2022-05-06 18:34 ` Rafael J. Wysocki
2022-05-06 20:48 ` Ian Cowan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnWJsS8OaCJssz89@fedora \
--to=ian@linux.cowan.aero \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.