From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5672838774931686037==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] mm: shrinkers: fix minmax.cocci warnings Date: Sat, 07 May 2022 16:34:49 +0800 Message-ID: In-Reply-To: <202205071632.qT7zlJoE-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============5672838774931686037== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com TO: Roman Gushchin From: kernel test robot mm/shrinker_debug.c:122:21-22: WARNING opportunity for min() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci Fixes: 12f77aac7ef2 ("mm: shrinkers: add scan interface for shrinker debugf= s") Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/rgushchin/linux.git shrinker.3 head: 12f77aac7ef21be765e90bb8e0b611e6b9085256 commit: 12f77aac7ef21be765e90bb8e0b611e6b9085256 [7/7] mm: shrinkers: add s= can interface for shrinker debugfs :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! mm/shrinker_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -119,7 +119,7 @@ static ssize_t shrinker_debugfs_scan_wri struct mem_cgroup *memcg =3D NULL; int nid; char kbuf[72]; - int read_len =3D size < (sizeof(kbuf) - 1) ? size : (sizeof(kbuf) - 1); + int read_len =3D min(size, sizeof(kbuf) - 1); ssize_t ret; = if (copy_from_user(kbuf, buf, read_len)) --===============5672838774931686037==--