From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1981904228120321597==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] mm: shrinkers: fix stream_open.cocci warnings Date: Sat, 07 May 2022 16:34:52 +0800 Message-ID: In-Reply-To: <202205071632.qT7zlJoE-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1981904228120321597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com TO: Roman Gushchin From: kernel test robot mm/shrinker_debug.c:107:8-24: WARNING: shrinker_debugfs_scan_fops: .write()= has stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci Fixes: 12f77aac7ef2 ("mm: shrinkers: add scan interface for shrinker debugf= s") Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/rgushchin/linux.git shrinker.3 head: 12f77aac7ef21be765e90bb8e0b611e6b9085256 commit: 12f77aac7ef21be765e90bb8e0b611e6b9085256 [7/7] mm: shrinkers: add s= can interface for shrinker debugfs :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! mm/shrinker_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -104,7 +104,7 @@ DEFINE_SHOW_ATTRIBUTE(shrinker_debugfs_c static int shrinker_debugfs_scan_open(struct inode *inode, struct file *fi= le) { file->private_data =3D inode->i_private; - return nonseekable_open(inode, file); + return stream_open(inode, file); } = static ssize_t shrinker_debugfs_scan_write(struct file *file, --===============1981904228120321597==--