From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Leonardo Bras" <leobras@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"John G Johnson" <john.g.johnson@oracle.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX
Date: Mon, 9 May 2022 15:14:37 +0100 [thread overview]
Message-ID: <YnkhzRGqZVwwIsLt@work-vm> (raw)
In-Reply-To: <YnbEuH3nmSUCQ4ao@xz-m1.local>
* Peter Xu (peterx@redhat.com) wrote:
> On Fri, May 06, 2022 at 10:57:54PM -0300, Leonardo Bras wrote:
> > diff --git a/io/channel-socket.c b/io/channel-socket.c
> > index 05c425abb8..f03a068f25 100644
> > --- a/io/channel-socket.c
> > +++ b/io/channel-socket.c
> > @@ -25,9 +25,18 @@
> > #include "io/channel-watch.h"
> > #include "trace.h"
> > #include "qapi/clone-visitor.h"
> > +#ifdef CONFIG_LINUX
> > +#include <linux/errqueue.h>
> > +#include <sys/socket.h>
> > +
> > +#if (defined(MSG_ZEROCOPY) && defined(SO_ZEROCOPY))
> > +#define QEMU_MSG_ZEROCOPY
> > +#endif
> > +#endif
> >
> > #define SOCKET_MAX_FDS 16
> >
> > +
>
> This line can be dropped when merge.
Done
> > SocketAddress *
> > qio_channel_socket_get_local_address(QIOChannelSocket *ioc,
> > Error **errp)
>
> This does look nicer, imho. :)
>
> Thanks!
>
> --
> Peter Xu
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-05-09 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 1:57 [PATCH v12 0/7] MSG_ZEROCOPY + multifd Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 1/7] QIOChannel: Add flags on io_writev and introduce io_flush callback Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 2/7] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX Leonardo Bras
2022-05-07 19:12 ` Peter Xu
2022-05-09 14:14 ` Dr. David Alan Gilbert [this message]
2022-05-07 1:57 ` [PATCH v12 3/7] migration: Add zero-copy-send parameter for QMP/HMP for Linux Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 4/7] migration: Add migrate_use_tls() helper Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 5/7] multifd: multifd_send_sync_main now returns negative on error Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 6/7] multifd: Send header packet without flags if zero-copy-send is enabled Leonardo Bras
2022-05-07 1:57 ` [PATCH v12 7/7] multifd: Implement zero copy write in multifd migration (multifd-zero-copy) Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnkhzRGqZVwwIsLt@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.