All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] slimbus: qcom: fix platform_get_irq.cocci warnings
Date: Tue, 10 May 2022 07:01:48 +0800	[thread overview]
Message-ID: <YnmdXJjaymcE1c+1@8ec64cbf5db8> (raw)
In-Reply-To: <202205100730.LEVP50Zt-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Miaoqian Lin <linmq006@gmail.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: linux-arm-msm(a)vger.kernel.org
CC: alsa-devel(a)alsa-project.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: fe503887eed6 ("slimbus: qcom: Fix IRQ check in qcom_slim_probe")
CC: Miaoqian Lin <linmq006@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus
head:   fe503887eed6ea528e144ec8dacfa1d47aa701ac
commit: fe503887eed6ea528e144ec8dacfa1d47aa701ac [1/1] slimbus: qcom: Fix IRQ check in qcom_slim_probe
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/slimbus/qcom-ctrl.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -511,7 +511,6 @@ static int qcom_slim_probe(struct platfo
 
 	ctrl->irq = platform_get_irq(pdev, 0);
 	if (ctrl->irq < 0) {
-		dev_err(&pdev->dev, "no slimbus IRQ\n");
 		return ctrl->irq;
 	}
 

      reply	other threads:[~2022-05-09 23:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 23:10 [char-misc:char-misc-linus 1/1] drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error kernel test robot
2022-05-09 23:01 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnmdXJjaymcE1c+1@8ec64cbf5db8 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.