From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BA4BC433EF for ; Tue, 10 May 2022 08:55:49 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.325316.547832 (Exim 4.92) (envelope-from ) id 1noLec-0003hD-Jw; Tue, 10 May 2022 08:55:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325316.547832; Tue, 10 May 2022 08:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLec-0003h6-GG; Tue, 10 May 2022 08:55:38 +0000 Received: by outflank-mailman (input) for mailman id 325316; Tue, 10 May 2022 08:55:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noLea-0003h0-S8 for xen-devel@lists.xenproject.org; Tue, 10 May 2022 08:55:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f403aeaf-d03e-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 10:55:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CFAB614A1; Tue, 10 May 2022 08:55:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF230C385A6; Tue, 10 May 2022 08:55:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f403aeaf-d03e-11ec-8fc4-03012f2f19d4 Date: Tue, 10 May 2022 09:55:28 +0100 From: Catalin Marinas To: Julien Grall Cc: Michal Orzel , xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2] xen/arm: Avoid overflow using MIDR_IMPLEMENTOR_MASK Message-ID: References: <20220505115906.380416-1-michal.orzel@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 10, 2022 at 09:27:29AM +0100, Julien Grall wrote: > Hi, > > On 10/05/2022 07:49, Michal Orzel wrote: > > On 05.05.2022 14:13, Catalin Marinas wrote: > > > On Thu, May 05, 2022 at 01:59:06PM +0200, Michal Orzel wrote: > > > > Value of macro MIDR_IMPLEMENTOR_MASK exceeds the range of integer > > > > and can lead to overflow. Currently there is no issue as it is used > > > > in an expression implicitly casted to u32 in MIDR_IS_CPU_MODEL_RANGE. > > > > To avoid possible problems, fix the macro. > > > > > > > > Signed-off-by: Michal Orzel > > > > Link: https://lore.kernel.org/r/20220426070603.56031-1-michal.orzel@arm.com > > > > Signed-off-by: Catalin Marinas > > > > Origin: git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git (48e6f22e25a4) > > > > --- > > > > Changes since v1: > > > > - add Origin tag as the patch was merged in upstream arm64 linux tree > > > > > > Note that there's always a risk that the commit Id will be changed > > > before it hits mainline (Linus' tree). > > > > > > > This commit is now in linux-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=48e6f22e25a44e43952db5fbb767dea0c9319cb2 > > so we can be sure that the SHA will stay unmodified there (and will be the same in Linus' tree). > > AFAIK, linux-next branch is just a merge of all the maintainers branch and > often rewritten. So there are no guarantee a commit id is valid until it > reached Linus' tree. Indeed. While I try not to rebase it, it may happen occasionally. > > Question to maintainers: > > Do you want me to update Origin to point to linux-next? > > So we have a link to the patch and a name. This should be sufficient to find > the commit. > > Therefore, I would simply on top of Origin: Yeah, just keep the link to the mailing list. I guess you can drop my Singed-off-by as well if it appears to be picked from the list rather than the kernel repo. If you want an ack: Acked-by: Catalin Marinas -- Catalin