From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50302C433EF for ; Tue, 10 May 2022 12:18:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3B24C8422A; Tue, 10 May 2022 14:18:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=short.pl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4A57E83C62; Tue, 10 May 2022 14:18:25 +0200 (CEST) Received: from mx01.ayax.eu (mx01.ayax.eu [188.137.98.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DFB9483C62 for ; Tue, 10 May 2022 14:18:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=short.pl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gszymaszek@short.pl Received: from [192.168.192.146] (port=36610 helo=nx64de-df6d00) by mx01.ayax.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noOoj-0003qh-TR; Tue, 10 May 2022 14:18:18 +0200 Date: Tue, 10 May 2022 14:18:16 +0200 From: Grzegorz Szymaszek To: Patrick Delaunay Cc: u-boot@lists.denx.de, Gabriel Fernandez , Sean Anderson , uboot-stm32@st-md-mailman.stormreply.com, Lukasz Majewski , Grzegorz Szymaszek Subject: Re: [Uboot-stm32] [PATCH 2/4] clk: stm32mp13: add a STM32MP13 RCC clock driver Message-ID: Mail-Followup-To: Patrick Delaunay , u-boot@lists.denx.de, Gabriel Fernandez , Sean Anderson , uboot-stm32@st-md-mailman.stormreply.com, Lukasz Majewski References: <20220510075114.1238086-1-patrick.delaunay@foss.st.com> <20220510095041.2.I98b0b23318f39ef6411b8f96c05f5b11b4cf5de7@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SzLTGRoezlSIG1Wz" Content-Disposition: inline In-Reply-To: <20220510095041.2.I98b0b23318f39ef6411b8f96c05f5b11b4cf5de7@changeid> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --SzLTGRoezlSIG1Wz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, May 10, 2022 at 09:51:11AM +0200, Patrick Delaunay wrote: > Introduce a minimal STM32MP13 RCC driver only to allow bind of RCC MISC > driver. Consider s/only/just/ and s/bind of/binding of the/. > diff --git a/drivers/clk/stm32/Makefile b/drivers/clk/stm32/Makefile > -%<- > obj-$(CONFIG_CLK_STM32MP1) +=3D clk_stm32mp1.o > +obj-$(CONFIG_CLK_STM32MP13) +=3D clk-stm32mp13.o > \ No newline at end of file Could you add a newline here? I think it was there in the previous patch. Also, note that the new file name seems to break the convention of using underscores. All the best --=20 Grzegorz --SzLTGRoezlSIG1Wz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEZT55kPBhnB69hD4ZeE9lGUIcpz4FAmJ6WAgACgkQeE9lGUIc pz559A//cAaHTDK6yVhH3rwgxgmjvl+0WOsJKIud8zCl9r17FAATQlY1xXXq7/Xs py5/xrBhwNvDwbWtcO1TqRGhGw3TGz1Nx3aSMrtcyrD8Lfm0poM2UKJsZ+URN458 DptIZZGbzcejvUENGRC84lfvVCo7GBLYvOjO6tq0GXZI4+H/iXpIllipzxQcIhVH zfiRRiuUvNFMf2Omm++hfgNVZHbpF22mVzNzd9PBrfIAKF3XhWPNTaMkwGvxN9+K QgQ/V4Aelap9bgb5i6E4A5dzXNygTe7lczZOIhi36zW8L0ad+av0COKOjlu6/Qrg ZhHGVQTb3pPGyJi/38YEcOKWGw0h5BO/UhURAtWFQlKk2NvRt4MaygMbfjo/mH8R /HEq9Y5lcgvNGx0dT+I2kTxA+1juTaGlYKDDl++m717Fc6kWiIKcRcMSExuw+UF7 qOLNkEu5zuUtmajP3yJtbXg3HwsWWsy67qZThphIg2haIVQ+531gZIx5b8/Dmg3w lktiM7l1dN79LFv38faJZWZNb1ngip9BFaRIPEsI2tFl8oUapbeNqbYoD91dWdR4 vaz7sbheLfjrTqGEpkB3bxSZPbJ+hOrIbfdMpMhpqVRiPhHTP7HWh9vVW3MSodVG D2AW12U4IMzCMN6eHRmugPdS6K5Yb1XkiPmToh2j6Ry+f5WThLI= =rFhj -----END PGP SIGNATURE----- --SzLTGRoezlSIG1Wz--