From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/3] tst_net.sh: Fix for disabled IPv6
Date: Tue, 10 May 2022 16:04:50 +0200 [thread overview]
Message-ID: <YnpxAhZQpOG2eoE2@pevik> (raw)
In-Reply-To: <Ynpm8zmnkyi4rBik@yuki>
Hi Cyril,
> > - tst_net_detect_ipv6 rhost
> > + [ "$TST_NET_IPV6_ENABLED" = 1 ] && tst_net_detect_ipv6 rhost
> That solves the case where lhost does not support ipv6 but rhost does,
> but there is still case where lhost does support it but rhost does not,
> to fix that we have to clear TST_NET_IPV6_ENABLED in the
> tst_net_detect_ipv6() as well.
Ah, correct, thanks!
> if [ $ret -eq 0 ]; then
> TST_NET_IPV6_ENABLED=1
> else
> TST_NET_IPV6_ENABLED=0
nit: I'd slightly prefer to use TST_NET_IPV6_ENABLED=
> tst_res TINFO "IPv6 disabled on $type"
> fi
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-10 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 6:51 [LTP] [PATCH v3 0/3] shell: Fixes for disabled IPv6 Petr Vorel
2022-05-10 6:51 ` [LTP] [PATCH v3 1/3] tst_net.sh: Fix " Petr Vorel
2022-05-10 12:14 ` Cyril Hrubis
2022-05-10 13:06 ` Petr Vorel
2022-05-10 13:21 ` Cyril Hrubis
2022-05-10 14:04 ` Petr Vorel [this message]
2022-05-10 6:51 ` [LTP] [PATCH v3 2/3] netns: Rewrite to use tst_net.sh Petr Vorel
2022-05-10 13:08 ` Cyril Hrubis
2022-05-10 14:00 ` Petr Vorel
2022-05-10 6:51 ` [LTP] [PATCH v3 3/3] netns: Rename netns_helper.sh -> netns_lib.sh Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnpxAhZQpOG2eoE2@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.