From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 183D8C433EF for ; Tue, 10 May 2022 17:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1kkrvoS+XVpHY9+6m5XwXNs0lCaveQFL0WdQkJ/gfZo=; b=qYtNKr5kBdz10n Ffw2MTQei93AvlG/ObxyKXEXGqBp9SI2qx8ImstdSrU0iel84aHlXiRLsjuVCMz/kP01x0c0zvMGl LtcFlATawcxsoLEA5GRPd2hVj8yF/94ENhCIcpxxIIWK/1ugn5GbeW8xNnjyMUn4Lva94wtfgeJhB 3nEz1uJgOS5XPY6ph9xDvON/L3FNArrqYDQJFYbC+q1Gp5Qh3kMGJyXxW/rkEhYcLUo285RUYHIQf f81Sf67Ai2mX2ApRh04gIWBOKpRdkNx1rpv0zwuXtCnJjUlAdotSFj23VkDrC+kMldALKv8oV5Bxd Ns4+cg2dj/DHkMTTXudQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTSg-003J6Y-8C; Tue, 10 May 2022 17:15:50 +0000 Received: from mail-oa1-f52.google.com ([209.85.160.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTSP-003J0B-Ma; Tue, 10 May 2022 17:15:36 +0000 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-edf3b6b0f2so18658059fac.9; Tue, 10 May 2022 10:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4enf849MalZJ94BbtP5EjviZoqMa/mYSymuWO+hQes=; b=hzc3rMR6BXgp+W+qWcXHRXY29qGEM0XyZDNdEOD2lHa1oFAR6LvgIakoKOlK2xtlDA J8B9mv7n33OAwZzhLpjw+umypXH+qBbm810+BBWfgRVa34WxMha6eCOc1bA6vfRgEYwS J1T/ymnxbipM7J7ZAnoQ8SswyfqFETSXGLa0ZDw1tkdJbDDzZlhKS/qw40J5CZYzc3a5 yImiYcCsGoDET4oR5yBYuZgbSIJHWv4UbYzygZETA1jJcxmRZnHix5xdLaKvNKE8XVMJ NbIxbbA4aG85PKA9OxDQx/D4j4BuCNoJ3iiw8hYaoqnaY4uScOC29KH2/PJ2OqgtcDqg 3+bA== X-Gm-Message-State: AOAM532bFSPdbP/cg9iZjFepkB74luwhYJEuAGn8djL68alZJQ27sNNb eIm4YhnIULacfuiQtrg9BQ== X-Google-Smtp-Source: ABdhPJwPVMnLqdMiqMekoFO1BpTerz9mA5hoHbPcCejjGrX5ztBsVFiV9PTz4T6oBBl8FMJlcsz0+A== X-Received: by 2002:a05:6871:889:b0:ed:daa1:d08 with SMTP id r9-20020a056871088900b000eddaa10d08mr641546oaq.256.1652202930679; Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m33-20020a056870562100b000edf80be4ecsm5667586oao.58.2022.05.10.10.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: (nullmailer pid 2222946 invoked by uid 1000); Tue, 10 May 2022 17:15:29 -0000 Date: Tue, 10 May 2022 12:15:29 -0500 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Message-ID: References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_101533_782191_FB6EAC47 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 231C1C433F5 for ; Tue, 10 May 2022 17:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oEO1TJqKgn29dW40/Q2yygyUGHULyzkF2FSjMMB6P9I=; b=PcQSVvCVcmOmY9 WFaJqsNyEIGkksbbiRIQYDa0AqLVqImB3JHmnlvHpMkcYyaSpmN7Gdn+6QBYNLoR3rqKe7Tt7l4XB xm5mBmI9St0dbEbxJlv4dOVY9W9Os2Dw+bphGd20+uyTccsLpjLeg0YFUa6h7vEC7Ttz14I5SGcEz SEMsEXL+JUsyzNwPsNZAtyEghrq3SwwcIh9n9Bsu6VgAYDmNlg78Fx2MQQuPOuLwXQsApryQgIiL1 y1il6iPF8M+4Z8Eedm5g/s7TiCty8e7+Gb1fbj3UfGdmIaemQQc4tnqYG1JmTI0+GsiAwMUhOJET+ 0VHxEOQEwX8Uken7L9/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTSX-003J3i-0Z; Tue, 10 May 2022 17:15:41 +0000 Received: from mail-oa1-f52.google.com ([209.85.160.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noTSP-003J0B-Ma; Tue, 10 May 2022 17:15:36 +0000 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-edf3b6b0f2so18658059fac.9; Tue, 10 May 2022 10:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4enf849MalZJ94BbtP5EjviZoqMa/mYSymuWO+hQes=; b=hzc3rMR6BXgp+W+qWcXHRXY29qGEM0XyZDNdEOD2lHa1oFAR6LvgIakoKOlK2xtlDA J8B9mv7n33OAwZzhLpjw+umypXH+qBbm810+BBWfgRVa34WxMha6eCOc1bA6vfRgEYwS J1T/ymnxbipM7J7ZAnoQ8SswyfqFETSXGLa0ZDw1tkdJbDDzZlhKS/qw40J5CZYzc3a5 yImiYcCsGoDET4oR5yBYuZgbSIJHWv4UbYzygZETA1jJcxmRZnHix5xdLaKvNKE8XVMJ NbIxbbA4aG85PKA9OxDQx/D4j4BuCNoJ3iiw8hYaoqnaY4uScOC29KH2/PJ2OqgtcDqg 3+bA== X-Gm-Message-State: AOAM532bFSPdbP/cg9iZjFepkB74luwhYJEuAGn8djL68alZJQ27sNNb eIm4YhnIULacfuiQtrg9BQ== X-Google-Smtp-Source: ABdhPJwPVMnLqdMiqMekoFO1BpTerz9mA5hoHbPcCejjGrX5ztBsVFiV9PTz4T6oBBl8FMJlcsz0+A== X-Received: by 2002:a05:6871:889:b0:ed:daa1:d08 with SMTP id r9-20020a056871088900b000eddaa10d08mr641546oaq.256.1652202930679; Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m33-20020a056870562100b000edf80be4ecsm5667586oao.58.2022.05.10.10.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: (nullmailer pid 2222946 invoked by uid 1000); Tue, 10 May 2022 17:15:29 -0000 Date: Tue, 10 May 2022 12:15:29 -0500 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Message-ID: References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_101533_782191_FB6EAC47 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C51C433FE for ; Tue, 10 May 2022 17:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244049AbiEJRTa (ORCPT ); Tue, 10 May 2022 13:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244232AbiEJRT2 (ORCPT ); Tue, 10 May 2022 13:19:28 -0400 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AC52BF314 for ; Tue, 10 May 2022 10:15:31 -0700 (PDT) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-edf9ddb312so18137557fac.8 for ; Tue, 10 May 2022 10:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4enf849MalZJ94BbtP5EjviZoqMa/mYSymuWO+hQes=; b=Un2M/BM3JgVH6kKKhL6u7Mxj3f99Xjin1PP7EoN0ZzCykrivVoFTHghR+88bnn4jdk 1iky6X4ragozD4a7JDHraeV5QBEtg2Y+OL1M2DkF+efF24ErqlSY+vbOdJL4yixG2GcH SXazme4vhXc3qS6/EBIvc0U1GCnYjrfbx3Uf4NoKgPruwf3I7EmgNQHxV3Am1vH/D9Ho K/ZS40xHfmKpnb5X6l09p/RttsKtLDEqMp8/Q/xvX7xluuNAV7cOIOIT14Jb33++rt3u EYUWFjRkgZK8o8FAqlpWnKnZ5PWd0jBwAKP9KM7/B9d0jG5IVnZSIuFJMFCUsAPd/OK+ /yfw== X-Gm-Message-State: AOAM532eAS3anlNJnaRvbc3Yp9TBe1dBF2fFUB2tCbHhPW5ArEw7V9BO X+WSTaK00Rb2AuZj7kz56G+FsDG4eQ== X-Google-Smtp-Source: ABdhPJwPVMnLqdMiqMekoFO1BpTerz9mA5hoHbPcCejjGrX5ztBsVFiV9PTz4T6oBBl8FMJlcsz0+A== X-Received: by 2002:a05:6871:889:b0:ed:daa1:d08 with SMTP id r9-20020a056871088900b000eddaa10d08mr641546oaq.256.1652202930679; Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m33-20020a056870562100b000edf80be4ecsm5667586oao.58.2022.05.10.10.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: (nullmailer pid 2222946 invoked by uid 1000); Tue, 10 May 2022 17:15:29 -0000 Date: Tue, 10 May 2022 12:15:29 -0500 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Message-ID: References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0D49C433EF for ; Tue, 10 May 2022 17:15:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28E4210F32E; Tue, 10 May 2022 17:15:32 +0000 (UTC) Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 764A210F295 for ; Tue, 10 May 2022 17:15:31 +0000 (UTC) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-ed8a3962f8so19073671fac.4 for ; Tue, 10 May 2022 10:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U4enf849MalZJ94BbtP5EjviZoqMa/mYSymuWO+hQes=; b=QvEoHTWbZKXxf49IrRyI+iYse/BLLnYFJIdad0lCMjfXTmG+efMqexq00l9TUA4G7D q83s1t4L31mFj5VEVkuVd9fM9rBv7+OecquphrREPiexjdXvf10gI3S1xV1fillx6rhc wagKs4X+WoiK9YDLyG+A/f8jMhgOkDe1hA9VHCThiq437VlKbWQ8y/l+z4d+bPtdjH7d CO+8lVFWHsajgGIv7CPlFIZ8fD4mwPMx9TDHhq27P2ZJWk7Y7UO+gY2bSj4TvD2NjPf8 Y+F5yfMW6gHxeL+0ZKcGpJHqhj9MakLN+M5KQI6w6KOfYXZW24ONogVzqH1ooGgBb9V4 P3QQ== X-Gm-Message-State: AOAM53227XcDG4LyYQ5SGWLkRvyV6xvr9L5wtnx7TikECwIb0m3Dobtr KzmxWWYaLoRTjt0bZCH1IA== X-Google-Smtp-Source: ABdhPJwPVMnLqdMiqMekoFO1BpTerz9mA5hoHbPcCejjGrX5ztBsVFiV9PTz4T6oBBl8FMJlcsz0+A== X-Received: by 2002:a05:6871:889:b0:ed:daa1:d08 with SMTP id r9-20020a056871088900b000eddaa10d08mr641546oaq.256.1652202930679; Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m33-20020a056870562100b000edf80be4ecsm5667586oao.58.2022.05.10.10.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 10:15:30 -0700 (PDT) Received: (nullmailer pid 2222946 invoked by uid 1000); Tue, 10 May 2022 17:15:29 -0000 Date: Tue, 10 May 2022 12:15:29 -0500 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Message-ID: References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 10, 2022 at 09:09:12AM +0200, Sascha Hauer wrote: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 You ran the dt checks, right? This should give you a warning. The correct thing is drop minItems if there's always 2 entries. > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > -- > 2.30.2 > >