All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>, Jiri Pirko <jiri@nvidia.com>,
	Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
Date: Wed, 11 May 2022 10:07:02 +0300	[thread overview]
Message-ID: <Yntgln3mRvtjlDMB@shredder> (raw)
In-Reply-To: <20220510220904.284552-1-vladimir.oltean@nxp.com>

On Wed, May 11, 2022 at 01:09:04AM +0300, Vladimir Oltean wrote:
> The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
> but due to the fact that we pass $tcflags which may have the value of
> "skip_sw", we force $h2 to offload a drop rule for dst_ip, something
> which it may not be able to do.
> 
> The selftest only wants to verify the hit count of this rule as a means
> of figuring out whether the packet was received, so remove the $tcflags
> for it and let it be done in software.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>

  reply	other threads:[~2022-05-11  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 22:09 [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2 Vladimir Oltean
2022-05-11  7:07 ` Ido Schimmel [this message]
2022-05-11 22:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yntgln3mRvtjlDMB@shredder \
    --to=idosch@idosch.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.