From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection
Date: Thu, 12 May 2022 09:39:15 +0100 [thread overview]
Message-ID: <YnzHswjOM1YLryDD@redhat.com> (raw)
In-Reply-To: <20220512080932.735962-5-lvivier@redhat.com>
On Thu, May 12, 2022 at 10:09:28AM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
>
> Other errors are treated as failure by net_stream_client_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> net/stream.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-05-12 9:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 8:09 [RFC PATCH v2 0/8] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 1/8] net: introduce convert_host_port() Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 2/8] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-05-13 11:21 ` Markus Armbruster
2022-06-09 20:52 ` Laurent Vivier
2022-06-15 11:56 ` Markus Armbruster
2022-05-12 8:09 ` [RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-05-13 11:44 ` Markus Armbruster
2022-06-14 21:42 ` Laurent Vivier
2022-06-15 11:46 ` Markus Armbruster
2022-06-20 9:12 ` Laurent Vivier
2022-06-20 11:22 ` Markus Armbruster
2022-06-20 12:09 ` Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection Laurent Vivier
2022-05-12 8:39 ` Daniel P. Berrangé [this message]
2022-05-12 8:09 ` [RFC PATCH v2 5/8] net: stream: add unix socket Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 6/8] net: dgram: make dgram_dst generic Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 7/8] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-05-12 8:09 ` [RFC PATCH v2 8/8] net: dgram: add unix socket Laurent Vivier
2022-05-13 18:27 ` [RFC PATCH v2 0/8] qapi: net: add unix socket type support to netdev backend Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnzHswjOM1YLryDD@redhat.com \
--to=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.