From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96FAC433EF for ; Thu, 12 May 2022 09:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349867AbiELJtq (ORCPT ); Thu, 12 May 2022 05:49:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232049AbiELJtp (ORCPT ); Thu, 12 May 2022 05:49:45 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8A603F304 for ; Thu, 12 May 2022 02:49:43 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id q23so6471240wra.1 for ; Thu, 12 May 2022 02:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m+GHfrW6fEuHc5Bs8OGRGQGWigIu1swhxgOxVtKpNhk=; b=dwGIQ0BkCa1E3CJvLrusI8PupUWwR7p+1hFOBj/+L8AjeAwkXB0MDERMHgBJdhDGzT nJlqSVX2eesukTMTMDhXG13WsiALG4nTQnhPW0lqClxlD/Pt2CZ6HcwTVPpq8htGKkVs Wj8OonXKuY/XIQhNxBpqwTd+E1x4rH1AFARunTtpBT9n+FpJH3Lt1Ehz3smX9gJqC7iU D+peMsK+SCpRCnwRpCAeQwqNsJxnqzcIFKut5MhQOnRb34TDVV0O7ed/m9Ta5OYFcfkv XxQDekIaWAJRf7O5gp2Ps6WKd+0HggV9t3i6jnt5xZTJ+aYAVIta6srR6nN67Oay4tUn if2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m+GHfrW6fEuHc5Bs8OGRGQGWigIu1swhxgOxVtKpNhk=; b=LQOBqIr1ksFjfvpBhkc3KDCmgVMmFM2ya50Ikj3Acv9NiJTcGwF5nkIE8aqceiU85i waWulba7zsGg9yONDRPMCtjhTieYhuPIdRDCses1i+RsvvCnIQv5OfimqDMwPKBf8Pnn TpnRogqs4ZYC1/NjOuGzTndw1dveHf2KFfpTnixwJKOXWJ95LWrY1YSIKrnZD6C/C153 osn6KynEqUkUGHGtd55YKgSIzAEJyGC1ftv4kyK2qdlU7N5Z9cCg6YrvxIqzJbr+gZv3 kcBv0G3oAzyaxw6GnN1nsuO3khaG5DqXp+orGxhSk9+mVaYRHPzybYIrnVnnXSYfdsgU mucQ== X-Gm-Message-State: AOAM533CKiBUwLcf2iyzmJ5Vu6gBaknckkSMPKLtld5cT8oKRkBkGqUC 61dMHowg7wYoiks6V0CXuEsjcw== X-Google-Smtp-Source: ABdhPJzJ8xq2tAa6Ub50g1TH/DdizJOEPl87cht3iCrjgVaclsdPRT2WWsCqIHuuIx0bKY2DJYFaBA== X-Received: by 2002:a5d:64c8:0:b0:20c:6970:fb22 with SMTP id f8-20020a5d64c8000000b0020c6970fb22mr25695147wri.424.1652348982423; Thu, 12 May 2022 02:49:42 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id d2-20020a056000114200b0020c6a524fe0sm3635878wrx.98.2022.05.12.02.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 02:49:41 -0700 (PDT) Date: Thu, 12 May 2022 10:49:39 +0100 From: Lee Jones To: Colin Foster Cc: Vladimir Oltean , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil Subject: Re: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-9-colin.foster@in-advantage.com> <20220509105239.wriaryaclzsq5ia3@skbuf> <20220509234922.GC895@COLIN-DESKTOP1.localdomain> <20220509172028.qcxzexnabovrdatq@skbuf> <20220510161319.GA872@COLIN-DESKTOP1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220510161319.GA872@COLIN-DESKTOP1.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, 10 May 2022, Colin Foster wrote: > On Tue, May 10, 2022 at 04:32:26PM +0100, Lee Jones wrote: > > On Mon, 09 May 2022, Vladimir Oltean wrote: > > > > > On Mon, May 09, 2022 at 04:49:22PM -0700, Colin Foster wrote: > > > > > > +struct regmap *ocelot_init_regmap_from_resource(struct device *child, > > > > > > + const struct resource *res) > > > > > > +{ > > > > > > + struct device *dev = child->parent; > > > > > > + > > > > > > + return ocelot_spi_devm_init_regmap(dev, child, res); > > > > > > > > > > So much for being bus-agnostic :-/ > > > > > Maybe get the struct ocelot_ddata and call ocelot_spi_devm_init_regmap() > > > > > via a function pointer which is populated by ocelot-spi.c? If you do > > > > > that don't forget to clean up drivers/mfd/ocelot.h of SPI specific stuff. > > > > > > > > That was my initial design. "core" was calling into "spi" exclusively > > > > via function pointers. > > > > > > > > The request was "Please find a clearer way to do this without function > > > > pointers" > > > > > > > > https://lore.kernel.org/netdev/Ydwju35sN9QJqJ%2FP@google.com/ > > > > > > Yeah, I'm not sure what Lee was looking for, either. In any case I agree > > > with the comment that you aren't configuring a bus. In this context it > > > seems more appropriate to call this function pointer "init_regmap", with > > > different implementations per transport. > > > > FWIW, I'm still against using function pointers for this. > > > > What about making ocelot_init_regmap_from_resource() an inline > > function and pushing it into one of the header files? > > > > [As an aside, you don't need to pass both dev (parent) and child] > > I see your point. This wasn't always the case, since ocelot-core prior > to v8 would call ocelot_spi_devm_init_regmap. Since this was changed, > the "dev, dev" part can all be handled internally. That's nice. > > > > > In there you could simply do: > > > > inline struct regmap *ocelot_init_regmap_from_resource(struct device *dev, > > const struct resource *res) > > { > > if (dev_get_drvdata(dev->parent)->spi) > > return ocelot_spi_devm_init_regmap(dev, res); > > > > return NULL; > > } > > If I do this, won't I have to declare ocelot_spi_devm_init_regmap in a > larger scope (include/soc/mscc/ocelot.h)? I like the idea of keeping it > more hidden inside drivers/mfd/ocelot.h, assuming I can't keep it > enclosed in drivers/mfd/ocelot-spi.c entirely. Yes, it will have the same scope as ocelot_init_regmap_from_resource(). Have you considered include/linux/mfd? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7363C433F5 for ; Thu, 12 May 2022 09:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LJcXUmnHvF/A60atB9ykXKBnzyRpjXvNDn+rqbV4Ybc=; b=Z9FGgcCReJ8959 H7P4Wc62ZG6wdMal+DbRIUl5wCwhdpCsdK+xvA8wvoi6eeNYyrhr9MXtliAtV5IL0hsYCp7Bi07uw 1FOu1iIUZdat2EzPJUQkYRJDiOR8Gw3adqO/VZkdColzU+Ar01fzI3kxvah0wAKIA94p1+ndfeinv 9WneNZMD1hif5AQXZfuFkMAoSdeYMpxS78U8B5cAZwhiQF5vsng6rkDCEPfaVZew4q3maDR84L9Np 751GyMtZskHYzKBTQvKueZ5waRr3xPmEPpt1qaF0m3M41oDW9j6CWmIgOqvnbh6SdeaIZN3VhA9Ck NBRr1Fwx8vEgzFEBLk+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1np5SA-00BDpu-Hg; Thu, 12 May 2022 09:49:50 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1np5S7-00BDoz-JU for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 09:49:49 +0000 Received: by mail-wr1-x42e.google.com with SMTP id q23so6471239wra.1 for ; Thu, 12 May 2022 02:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m+GHfrW6fEuHc5Bs8OGRGQGWigIu1swhxgOxVtKpNhk=; b=dwGIQ0BkCa1E3CJvLrusI8PupUWwR7p+1hFOBj/+L8AjeAwkXB0MDERMHgBJdhDGzT nJlqSVX2eesukTMTMDhXG13WsiALG4nTQnhPW0lqClxlD/Pt2CZ6HcwTVPpq8htGKkVs Wj8OonXKuY/XIQhNxBpqwTd+E1x4rH1AFARunTtpBT9n+FpJH3Lt1Ehz3smX9gJqC7iU D+peMsK+SCpRCnwRpCAeQwqNsJxnqzcIFKut5MhQOnRb34TDVV0O7ed/m9Ta5OYFcfkv XxQDekIaWAJRf7O5gp2Ps6WKd+0HggV9t3i6jnt5xZTJ+aYAVIta6srR6nN67Oay4tUn if2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m+GHfrW6fEuHc5Bs8OGRGQGWigIu1swhxgOxVtKpNhk=; b=H1Vr7+vDHM9u9Pp2x/Fo0Ho/j9Rgy3V/lqMWwl5PXZj6wbL6RF5B1ukHyyiISsK6IC 1R4rxVo397xVXOwlFJLF2wSWe3UcPjRWpZfnHlxhv9r2IEWvkrb4dGjUxOdU+sCQV0p5 btUeaHbG6+elOqdPNYEZg7UsYCfzvqXKNSkPVirP+6Zt/6K2JECDDRuMynt5M/+cg6KH l3Q8eDyFx3Tj9DE/ixPO7uqplJzaP27SRifl6/FmGi3jc0sqvjNTR58ynyWIJMrAKfX+ uxN9g0eG96JL+6exs4Npi/cTOY/mhx/4s5H5w2v11/zLO4OPr7TnKTlv26qcBPDv4OpB VYug== X-Gm-Message-State: AOAM53248FxgYWQRvYIF7Rbk+9Wr/MBOt3JhZeTpzOaijscwqHQePNfH C/ixnUWUoJku5G8TQXUF7+JIqQ== X-Google-Smtp-Source: ABdhPJzJ8xq2tAa6Ub50g1TH/DdizJOEPl87cht3iCrjgVaclsdPRT2WWsCqIHuuIx0bKY2DJYFaBA== X-Received: by 2002:a5d:64c8:0:b0:20c:6970:fb22 with SMTP id f8-20020a5d64c8000000b0020c6970fb22mr25695147wri.424.1652348982423; Thu, 12 May 2022 02:49:42 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id d2-20020a056000114200b0020c6a524fe0sm3635878wrx.98.2022.05.12.02.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 02:49:41 -0700 (PDT) Date: Thu, 12 May 2022 10:49:39 +0100 From: Lee Jones To: Colin Foster Cc: Vladimir Oltean , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "netdev@vger.kernel.org" , Terry Bowman , Wolfram Sang , Andy Shevchenko , Steen Hegelund , Lars Povlsen , Linus Walleij , Russell King , Heiner Kallweit , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Vivien Didelot , Andrew Lunn , "UNGLinuxDriver@microchip.com" , Alexandre Belloni , Claudiu Manoil Subject: Re: [RFC v8 net-next 08/16] mfd: ocelot: add support for the vsc7512 chip via spi Message-ID: References: <20220508185313.2222956-1-colin.foster@in-advantage.com> <20220508185313.2222956-9-colin.foster@in-advantage.com> <20220509105239.wriaryaclzsq5ia3@skbuf> <20220509234922.GC895@COLIN-DESKTOP1.localdomain> <20220509172028.qcxzexnabovrdatq@skbuf> <20220510161319.GA872@COLIN-DESKTOP1.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220510161319.GA872@COLIN-DESKTOP1.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220512_024947_694418_276F0E95 X-CRM114-Status: GOOD ( 31.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMCBNYXkgMjAyMiwgQ29saW4gRm9zdGVyIHdyb3RlOgoKPiBPbiBUdWUsIE1heSAx MCwgMjAyMiBhdCAwNDozMjoyNlBNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBNb24s IDA5IE1heSAyMDIyLCBWbGFkaW1pciBPbHRlYW4gd3JvdGU6Cj4gPiAKPiA+ID4gT24gTW9uLCBN YXkgMDksIDIwMjIgYXQgMDQ6NDk6MjJQTSAtMDcwMCwgQ29saW4gRm9zdGVyIHdyb3RlOgo+ID4g PiA+ID4gPiArc3RydWN0IHJlZ21hcCAqb2NlbG90X2luaXRfcmVnbWFwX2Zyb21fcmVzb3VyY2Uo c3RydWN0IGRldmljZSAqY2hpbGQsCj4gPiA+ID4gPiA+ICsJCQkJCQljb25zdCBzdHJ1Y3QgcmVz b3VyY2UgKnJlcykKPiA+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ID4gKwlzdHJ1Y3QgZGV2aWNlICpk ZXYgPSBjaGlsZC0+cGFyZW50Owo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICsJcmV0dXJuIG9j ZWxvdF9zcGlfZGV2bV9pbml0X3JlZ21hcChkZXYsIGNoaWxkLCByZXMpOwo+ID4gPiA+ID4gCj4g PiA+ID4gPiBTbyBtdWNoIGZvciBiZWluZyBidXMtYWdub3N0aWMgOi0vCj4gPiA+ID4gPiBNYXli ZSBnZXQgdGhlIHN0cnVjdCBvY2Vsb3RfZGRhdGEgYW5kIGNhbGwgb2NlbG90X3NwaV9kZXZtX2lu aXRfcmVnbWFwKCkKPiA+ID4gPiA+IHZpYSBhIGZ1bmN0aW9uIHBvaW50ZXIgd2hpY2ggaXMgcG9w dWxhdGVkIGJ5IG9jZWxvdC1zcGkuYz8gSWYgeW91IGRvCj4gPiA+ID4gPiB0aGF0IGRvbid0IGZv cmdldCB0byBjbGVhbiB1cCBkcml2ZXJzL21mZC9vY2Vsb3QuaCBvZiBTUEkgc3BlY2lmaWMgc3R1 ZmYuCj4gPiA+ID4gCj4gPiA+ID4gVGhhdCB3YXMgbXkgaW5pdGlhbCBkZXNpZ24uICJjb3JlIiB3 YXMgY2FsbGluZyBpbnRvICJzcGkiIGV4Y2x1c2l2ZWx5Cj4gPiA+ID4gdmlhIGZ1bmN0aW9uIHBv aW50ZXJzLgo+ID4gPiA+IAo+ID4gPiA+IFRoZSByZXF1ZXN0IHdhcyAiUGxlYXNlIGZpbmQgYSBj bGVhcmVyIHdheSB0byBkbyB0aGlzIHdpdGhvdXQgZnVuY3Rpb24KPiA+ID4gPiBwb2ludGVycyIK PiA+ID4gPiAKPiA+ID4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9uZXRkZXYvWWR3anUzNXNO OVFKcUolMkZQQGdvb2dsZS5jb20vCj4gPiA+IAo+ID4gPiBZZWFoLCBJJ20gbm90IHN1cmUgd2hh dCBMZWUgd2FzIGxvb2tpbmcgZm9yLCBlaXRoZXIuIEluIGFueSBjYXNlIEkgYWdyZWUKPiA+ID4g d2l0aCB0aGUgY29tbWVudCB0aGF0IHlvdSBhcmVuJ3QgY29uZmlndXJpbmcgYSBidXMuIEluIHRo aXMgY29udGV4dCBpdAo+ID4gPiBzZWVtcyBtb3JlIGFwcHJvcHJpYXRlIHRvIGNhbGwgdGhpcyBm dW5jdGlvbiBwb2ludGVyICJpbml0X3JlZ21hcCIsIHdpdGgKPiA+ID4gZGlmZmVyZW50IGltcGxl bWVudGF0aW9ucyBwZXIgdHJhbnNwb3J0Lgo+ID4gCj4gPiBGV0lXLCBJJ20gc3RpbGwgYWdhaW5z dCB1c2luZyBmdW5jdGlvbiBwb2ludGVycyBmb3IgdGhpcy4KPiA+IAo+ID4gV2hhdCBhYm91dCBt YWtpbmcgb2NlbG90X2luaXRfcmVnbWFwX2Zyb21fcmVzb3VyY2UoKSBhbiBpbmxpbmUKPiA+IGZ1 bmN0aW9uIGFuZCBwdXNoaW5nIGl0IGludG8gb25lIG9mIHRoZSBoZWFkZXIgZmlsZXM/Cj4gPiAK PiA+IFtBcyBhbiBhc2lkZSwgeW91IGRvbid0IG5lZWQgdG8gcGFzcyBib3RoIGRldiAocGFyZW50 KSBhbmQgY2hpbGRdCj4gCj4gSSBzZWUgeW91ciBwb2ludC4gVGhpcyB3YXNuJ3QgYWx3YXlzIHRo ZSBjYXNlLCBzaW5jZSBvY2Vsb3QtY29yZSBwcmlvcgo+IHRvIHY4IHdvdWxkIGNhbGwgb2NlbG90 X3NwaV9kZXZtX2luaXRfcmVnbWFwLiBTaW5jZSB0aGlzIHdhcyBjaGFuZ2VkLAo+IHRoZSAiZGV2 LCBkZXYiIHBhcnQgY2FuIGFsbCBiZSBoYW5kbGVkIGludGVybmFsbHkuIFRoYXQncyBuaWNlLgo+ IAo+ID4gCj4gPiBJbiB0aGVyZSB5b3UgY291bGQgc2ltcGx5IGRvOgo+ID4gCj4gPiBpbmxpbmUg c3RydWN0IHJlZ21hcCAqb2NlbG90X2luaXRfcmVnbWFwX2Zyb21fcmVzb3VyY2Uoc3RydWN0IGRl dmljZSAqZGV2LAo+ID4gCQkJCQkJICAgICAgIGNvbnN0IHN0cnVjdCByZXNvdXJjZSAqcmVzKQo+ ID4gewo+ID4gCWlmIChkZXZfZ2V0X2RydmRhdGEoZGV2LT5wYXJlbnQpLT5zcGkpCj4gPiAJCXJl dHVybiBvY2Vsb3Rfc3BpX2Rldm1faW5pdF9yZWdtYXAoZGV2LCByZXMpOwo+ID4gCj4gPiAJcmV0 dXJuIE5VTEw7Cj4gPiB9Cj4gCj4gSWYgSSBkbyB0aGlzLCB3b24ndCBJIGhhdmUgdG8gZGVjbGFy ZSBvY2Vsb3Rfc3BpX2Rldm1faW5pdF9yZWdtYXAgaW4gYQo+IGxhcmdlciBzY29wZSAoaW5jbHVk ZS9zb2MvbXNjYy9vY2Vsb3QuaCk/IEkgbGlrZSB0aGUgaWRlYSBvZiBrZWVwaW5nIGl0Cj4gbW9y ZSBoaWRkZW4gaW5zaWRlIGRyaXZlcnMvbWZkL29jZWxvdC5oLCBhc3N1bWluZyBJIGNhbid0IGtl ZXAgaXQKPiBlbmNsb3NlZCBpbiBkcml2ZXJzL21mZC9vY2Vsb3Qtc3BpLmMgZW50aXJlbHkuCgpZ ZXMsIGl0IHdpbGwgaGF2ZSB0aGUgc2FtZSBzY29wZSBhcyBvY2Vsb3RfaW5pdF9yZWdtYXBfZnJv bV9yZXNvdXJjZSgpLgoKSGF2ZSB5b3UgY29uc2lkZXJlZCBpbmNsdWRlL2xpbnV4L21mZD8KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KUHJpbmNpcGFsIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxv cGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0g U29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==