From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95512C433EF for ; Thu, 26 May 2022 15:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347908AbiEZPXs (ORCPT ); Thu, 26 May 2022 11:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347951AbiEZPXp (ORCPT ); Thu, 26 May 2022 11:23:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EF48DE300; Thu, 26 May 2022 08:23:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 615C9B82109; Thu, 26 May 2022 15:23:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5B4CC385A9; Thu, 26 May 2022 15:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653578617; bh=6IZVvCtc7AKK6GVlmV/StJi7IokuGgZrQ4pffitComI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gWLh3x8hTHfc3XVWzw0drhsYAdxY7X78BlpxOCN5/C3Gex4UdWsK3fx/RlQ26bLEY oNNlA+PfF9nwIs9qpw/co8Y60+N+nrZCjg+rBegpXKwkY5OlCkariD5DmOwArOsAZN 4+zeCESL3GKwxXAYyKCQsNRWakMIPb8mlptX6lN7SbQi0AxByIzbY0nk992z+RyDm6 8TRCak9QOoRnBxwvhJ7yZMNShV3QfQmpPsk2Ni74fLbbj4aAVjnJOVNLRfj52IeEGv 4PsyfMBpIieNKAg9R45lTvluE+XHguYsXoVZnskrfGuHuPc57XiQVb7F4KC+gOZfoB LW5tglrTkpngg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 055ED4036D; Thu, 26 May 2022 12:23:33 -0300 (-03) Date: Thu, 26 May 2022 12:23:33 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, german.gomez@arm.com, leo.yan@linaro.org, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions Message-ID: References: <20220525154114.718321-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220525154114.718321-1-james.clark@arm.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Wed, May 25, 2022 at 04:41:09PM +0100, James Clark escreveu: > Changes since v2: > * Add commit to fix header include path to use Perf's copy > * Apply Leo's review tags > > When SVE registers are pushed onto the stack the VG register is required to > unwind because the stack offsets would vary by the SVE register width at the > time when the sample was taken. > > The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding > through SVE functions") add support for sampling the VG register to the kernel > and the docs. This is the patchset to add support to userspace perf. > > A small change is also required to libunwind or libdw depending on which > unwinder is used, and these will be published later. Without these changes Perf > continues to work with both libraries, although the VG register is still not > used for unwinding. Thanks, applied. - Arnaldo > Thanks > James > > James Clark (5): > perf tools: arm64: Use perf's copy of kernel headers > perf tools: arm64: Copy perf_regs.h from the kernel > perf tools: Use dynamic register set for Dwarf unwind > perf tools: arm64: Decouple Libunwind register names from Perf > perf tools: arm64: Add support for VG register > > tools/arch/arm64/include/uapi/asm/perf_regs.h | 7 +- > tools/perf/arch/arm64/util/perf_regs.c | 34 +++++++++ > tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------ > tools/perf/util/evsel.c | 2 +- > tools/perf/util/libunwind/arm64.c | 2 +- > tools/perf/util/perf_regs.c | 2 + > 6 files changed, 46 insertions(+), 74 deletions(-) > > -- > 2.28.0 -- - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72E6FC433F5 for ; Thu, 26 May 2022 15:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SlsWaRmNcuO6CUYeY6G386bLJ3NPmsBFSdW4b+wUp38=; b=EOEJg3S7k+EPYx ThrO+1fog4KVRLLuA+3n/zbrGFRsnojOHAAHoGK8BHcmZ8mA1BudW6nhLTVncLx102ZvfQzUZ8dSY cRSHHIRWIEpaEAPhTiHQwYn4BvdBmuT0s+SbUkT7d/+/dZw6QEkc8Gu91oh6KTvRYrCtRH72xqvaN TR2eNsbWPfw/b7Mbg6qMuUR1PGsjMRyzkToWk1ZyMIvqTRTdLufrAUeA6bqOSRzMUb2CUgHYe4pqa 9fpZXG9F1MR+wBXg3x2khhR8CCgMJDt7z7iyQRywjPNetzAIiWuZoM6bgMwcPyLkEgWTmP2fl5Wu4 ZCSNLayG6C4ZxJ4tyj2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFL4-00FJF3-Bi; Thu, 26 May 2022 15:23:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFL2-00FJEl-Lj for linux-arm-kernel@bombadil.infradead.org; Thu, 26 May 2022 15:23:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Zvo2/qRr6VdrrzSrXrWkS6N8GrzX5l2kT72u6Uk0ivk=; b=rW9Lp8bnK2/rjXMqMJMp71Jtel 3miHQTQj+cVVIRNoJAJdXHVQuEHmNW4kWfYXYhZYLn5cCPv9TWbGiNxJaUPsi0GiL196WxRTWAa8p 3TZOFFazJNSAHdySwWm1x6wkBJprhRT8/J69WDpoxIiXBFFVuCkch3jlBtJbg2/Es47dkQFFPPCF1 uf8FpTeBFfg17Xp7jmqcOU3PjazrUIQtUBNQidjZgcMIDGW/8nuegF1cNUtTapJJu/IbVB2wD4Hbj /aM84sD77Q/jR1bK2QKUEuwcjzDTGU61/BWEkACferWoyL4g7rlP/wrKs+gtMdcGrGV5IEfOiguW0 KZ26kMjA==; Received: from [187.19.239.237] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuFKs-001vEY-Tx; Thu, 26 May 2022 15:23:39 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 055ED4036D; Thu, 26 May 2022 12:23:33 -0300 (-03) Date: Thu, 26 May 2022 12:23:33 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, german.gomez@arm.com, leo.yan@linaro.org, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] perf: arm64: Tools support for Dwarf unwinding through SVE functions Message-ID: References: <20220525154114.718321-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220525154114.718321-1-james.clark@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, May 25, 2022 at 04:41:09PM +0100, James Clark escreveu: > Changes since v2: > * Add commit to fix header include path to use Perf's copy > * Apply Leo's review tags > > When SVE registers are pushed onto the stack the VG register is required to > unwind because the stack offsets would vary by the SVE register width at the > time when the sample was taken. > > The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding > through SVE functions") add support for sampling the VG register to the kernel > and the docs. This is the patchset to add support to userspace perf. > > A small change is also required to libunwind or libdw depending on which > unwinder is used, and these will be published later. Without these changes Perf > continues to work with both libraries, although the VG register is still not > used for unwinding. Thanks, applied. - Arnaldo > Thanks > James > > James Clark (5): > perf tools: arm64: Use perf's copy of kernel headers > perf tools: arm64: Copy perf_regs.h from the kernel > perf tools: Use dynamic register set for Dwarf unwind > perf tools: arm64: Decouple Libunwind register names from Perf > perf tools: arm64: Add support for VG register > > tools/arch/arm64/include/uapi/asm/perf_regs.h | 7 +- > tools/perf/arch/arm64/util/perf_regs.c | 34 +++++++++ > tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------ > tools/perf/util/evsel.c | 2 +- > tools/perf/util/libunwind/arm64.c | 2 +- > tools/perf/util/perf_regs.c | 2 + > 6 files changed, 46 insertions(+), 74 deletions(-) > > -- > 2.28.0 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel