From: Roman Gushchin <roman.gushchin@linux.dev>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Richard Palethorpe <rpalethorpe@suse.de>,
Muhammad Usama Anjum <usama.anjum@collabora.com>
Subject: Re: [PATCH v3 5/5] selftests: memcg: Factor out common parts of memory.{low,min} tests
Date: Tue, 24 May 2022 19:26:05 -0700 [thread overview]
Message-ID: <Yo2TvWr/0Y6s9SE2@carbon> (raw)
In-Reply-To: <20220524162955.8635-6-mkoutny@suse.com>
On Tue, May 24, 2022 at 06:29:55PM +0200, Michal Koutny wrote:
> The memory protection test setup and runtime is almost equal for
> memory.low and memory.min cases.
> It makes modification of the common parts prone to mistakes, since the
> protections are similar not only in setup but also in principle, factor
> the common part out.
>
> Past exceptions between the tests:
> - missing memory.min is fine (kept),
> - test_memcg_low protected orphaned pagecache (adapted like
> test_memcg_min and we keep the processes of protected memory running).
>
> The evaluation in two tests is different (OOM of allocator vs low events
> of protégés), this is kept different.
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
prev parent reply other threads:[~2022-05-25 2:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 16:29 [PATCH v3 0/5] memcontrol selftests fixups Michal Koutný
2022-05-24 16:29 ` Michal Koutný
[not found] ` <20220524162955.8635-1-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-24 16:29 ` [PATCH v3 1/5] selftests: memcg: Fix compilation Michal Koutný
2022-05-24 16:29 ` Michal Koutný
2022-05-24 16:29 ` [PATCH v3 2/5] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
2022-05-24 16:29 ` Michal Koutný
[not found] ` <20220524162955.8635-3-mkoutny-IBi9RG/b67k@public.gmane.org>
2022-05-25 2:27 ` Roman Gushchin
2022-05-25 2:27 ` Roman Gushchin
2022-05-24 16:29 ` [PATCH v3 3/5] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný
2022-05-24 16:29 ` Michal Koutný
2022-05-24 16:29 ` [PATCH v3 4/5] selftests: memcg: Remove protection from top level memcg Michal Koutný
2022-05-24 16:29 ` Michal Koutný
2022-05-24 16:29 ` [PATCH v3 5/5] selftests: memcg: Factor out common parts of memory.{low,min} tests Michal Koutný
2022-05-24 16:29 ` Michal Koutný
2022-05-25 2:26 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo2TvWr/0Y6s9SE2@carbon \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=rpalethorpe@suse.de \
--cc=shakeelb@google.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.