From: Leon Romanovsky <leon@kernel.org>
To: Ryan Stone <rysto32@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: Possible bug in ipoib_reap_dead_ahs in datagram mode
Date: Wed, 25 May 2022 09:10:16 +0300 [thread overview]
Message-ID: <Yo3ISBaM3awcm1o6@unreal> (raw)
In-Reply-To: <CAFMmRNx0wgPQRhMpHz+9h9fXv-bPbzPDRmwtZrHqYSc5WHmfHQ@mail.gmail.com>
On Tue, May 24, 2022 at 03:18:53PM -0400, Ryan Stone wrote:
> I believe that if we never enter that if statement, then we will leak
> the entries that are supposed to be cleaned up. That's better than
> the use-after-free that I feared but still not good.
I don't know, we are running enhanced IPoIB all the time and I never got
any reports about kmemleaks/KASAN in that area.
Thanks
>
> On Tue, May 24, 2022 at 3:08 PM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Tue, May 24, 2022 at 09:33:52AM -0400, Ryan Stone wrote:
> > > On Tue, May 24, 2022 at 3:07 AM Leon Romanovsky <leon@kernel.org> wrote:
> > > > IPoIB in mlx5 is HW offloaded version of ulp/ipoib one. AFAIK, it doesn't
> > > > change "tx_tail" and we won't enter into this if (...).
> > > >
> > > > Thanks
> > >
> > > I don't quite follow this response. Is this the if statement that you
> > > mean that we won't fall into?
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/ulp/ipoib/ipoib_ib.c#n682
> >
> > Yes, I think so, maybe wrong here.
prev parent reply other threads:[~2022-05-25 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 19:15 Possible bug in ipoib_reap_dead_ahs in datagram mode Ryan Stone
2022-05-24 7:07 ` Leon Romanovsky
2022-05-24 13:33 ` Ryan Stone
2022-05-24 19:08 ` Leon Romanovsky
2022-05-24 19:18 ` Ryan Stone
2022-05-25 6:10 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3ISBaM3awcm1o6@unreal \
--to=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rysto32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.