From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Mark Brown <broonie@kernel.org>, Will Deacon <will@kernel.org>,
Marc Zyngier <maz@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] arm64/sysregs: Align field names in ID_AA64DFR0_EL1 with architecture
Date: Wed, 25 May 2022 10:07:14 +0100 [thread overview]
Message-ID: <Yo3xwmydoy61qh++@arm.com> (raw)
In-Reply-To: <Yo3s1TvWPJ0YrUJE@FVFF77S0Q05N>
On Wed, May 25, 2022 at 09:46:13AM +0100, Mark Rutland wrote:
> On Wed, May 18, 2022 at 03:57:50PM +0100, Mark Brown wrote:
> > The naming scheme the architecture uses for the fields in ID_AA64DFR0_EL1
> > does not align well with kernel conventions, using as it does a lot of
> > MixedCase in various arrangements. In preparation for automatically
> > generating the defines for this register rename the defines used to match
> > what is in the architecture.
> >
> > Signed-off-by: Mark Brown <broonie@kernel.org>
> > ---
> >
> > I am not entirely convinced if the best approach here is to deviate from
> > the kernel naming convention as this does or to follow the architecture
> > as we've decided in other cases, I don't really mind but would like some
> > feedback before going ahead and sorting out the remaining issues with
> > this register.
>
> It's unfortunate the architecture itself doesn't follow a consistent pattern.
> :/
>
> I don't personally have strong feelings here. I'm happy with either:
>
> (a) Matching the case to the architectural names, even if that means some
> fields are MixedCase, as with this patch
>
> (b) Always using ALLCAPS for ID reg field definitions.
>
> Catalin/Marc/Will, any preference?
I don't have a preference either. We have some limited mixed case places
but mostly with a single 'n'. As we go for the automatic generation of
these macros, it makes some sense to keep them aligned with the
architecture. My only worry with (a) is the diffstat and potential
conflicts.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-25 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 14:57 [PATCH RFC] arm64/sysregs: Align field names in ID_AA64DFR0_EL1 with architecture Mark Brown
2022-05-25 8:46 ` Mark Rutland
2022-05-25 9:07 ` Catalin Marinas [this message]
2022-05-25 9:27 ` Will Deacon
2022-05-25 12:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3xwmydoy61qh++@arm.com \
--to=catalin.marinas@arm.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.