From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@chinatelecom.cn
Cc: netfilter-devel@vger.kernel.org, sven.auhagen@voleatech.de
Subject: Re: [PATCH nf-next] netfilter: flowtable: fix nft_flow_route use saddr for reverse route
Date: Wed, 25 May 2022 20:44:56 +0200 [thread overview]
Message-ID: <Yo55KCPBfIk46hxv@salvia> (raw)
In-Reply-To: <1653495837-75877-1-git-send-email-wenxu@chinatelecom.cn>
On Wed, May 25, 2022 at 12:23:57PM -0400, wenxu@chinatelecom.cn wrote:
> From: wenxu <wenxu@chinatelecom.cn>
>
> The nf_flow_tabel get route through ip_route_output_key which
> the saddr should be local ones. For the forward case it always
> can't get the other_dst and can't offload any flows
>
> Fixes: 3412e1641828 (netfilter: flowtable: nft_flow_route use more data for reverse route)
> Signed-off-by: wenxu <wenxu@chinatelecom.cn>
> ---
> net/netfilter/nft_flow_offload.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c
> index 40d18aa..742a494 100644
> --- a/net/netfilter/nft_flow_offload.c
> +++ b/net/netfilter/nft_flow_offload.c
> @@ -230,7 +230,6 @@ static int nft_flow_route(const struct nft_pktinfo *pkt,
> switch (nft_pf(pkt)) {
> case NFPROTO_IPV4:
> fl.u.ip4.daddr = ct->tuplehash[dir].tuple.src.u3.ip;
> - fl.u.ip4.saddr = ct->tuplehash[dir].tuple.dst.u3.ip;
I think this should be instead:
fl.u.ip4.saddr = ct->tuplehash[!dir].tuple.src.u3.ip;
to accordingly deal with snat and dnat.
> fl.u.ip4.flowi4_oif = nft_in(pkt)->ifindex;
> fl.u.ip4.flowi4_iif = this_dst->dev->ifindex;
> fl.u.ip4.flowi4_tos = RT_TOS(ip_hdr(pkt->skb)->tos);
> @@ -238,7 +237,6 @@ static int nft_flow_route(const struct nft_pktinfo *pkt,
> break;
> case NFPROTO_IPV6:
> fl.u.ip6.daddr = ct->tuplehash[dir].tuple.src.u3.in6;
> - fl.u.ip6.saddr = ct->tuplehash[dir].tuple.dst.u3.in6;
fl.u.ip6.saddr = ct->tuplehash[!dir].tuple.src.u3.in6;
> fl.u.ip6.flowi6_oif = nft_in(pkt)->ifindex;
> fl.u.ip6.flowi6_iif = this_dst->dev->ifindex;
> fl.u.ip6.flowlabel = ip6_flowinfo(ipv6_hdr(pkt->skb));
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2022-05-25 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 16:23 [PATCH nf-next] netfilter: flowtable: fix nft_flow_route use saddr for reverse route wenxu
2022-05-25 18:44 ` Pablo Neira Ayuso [this message]
2022-05-25 20:09 ` Sven Auhagen
2022-05-26 1:22 ` wenxu
2022-05-26 1:22 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo55KCPBfIk46hxv@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sven.auhagen@voleatech.de \
--cc=wenxu@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.