From: Andrew Lunn <andrew@lunn.ch>
To: Tan Tee Min <tee.min.tan@linux.intel.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dan Murphy <dmurphy@ti.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Voon Wei Feng <weifeng.voon@intel.com>,
Sit Michael Wei Hong <michael.wei.hong.sit@intel.com>,
Ling Pei Lee <pei.lee.ling@intel.com>,
Looi Hong Aun <hong.aun.looi@intel.com>,
Wong Vee Khee <vee.khee.wong@intel.com>,
Tan Tee Min <tee.min.tan@intel.com>
Subject: Re: [PATCH net-next v2 1/1] net: phy: dp83867: retrigger SGMII AN when link change
Date: Thu, 26 May 2022 14:32:14 +0200 [thread overview]
Message-ID: <Yo9zTmMduwel8XeZ@lunn.ch> (raw)
In-Reply-To: <20220526090347.128742-1-tee.min.tan@linux.intel.com>
On Thu, May 26, 2022 at 05:03:47PM +0800, Tan Tee Min wrote:
> There is a limitation in TI DP83867 PHY device where SGMII AN is only
> triggered once after the device is booted up. Even after the PHY TPI is
> down and up again, SGMII AN is not triggered and hence no new in-band
> message from PHY to MAC side SGMII.
>
> This could cause an issue during power up, when PHY is up prior to MAC.
> At this condition, once MAC side SGMII is up, MAC side SGMII wouldn`t
> receive new in-band message from TI PHY with correct link status, speed
> and duplex info.
>
> As suggested by TI, implemented a SW solution here to retrigger SGMII
> Auto-Neg whenever there is a link change.
Is there a bit in the PHY which reports host side link? There is no
point triggering an AN if there is already link.
Andrew
next prev parent reply other threads:[~2022-05-26 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 9:03 [PATCH net-next v2 1/1] net: phy: dp83867: retrigger SGMII AN when link change Tan Tee Min
2022-05-26 12:32 ` Andrew Lunn [this message]
2022-05-27 1:47 ` Tan Tee Min
2022-05-27 12:43 ` Andrew Lunn
2022-05-30 7:33 ` Tan Tee Min
2022-06-06 12:42 ` Andrew Lunn
2022-06-06 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo9zTmMduwel8XeZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hong.aun.looi@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pei.lee.ling@intel.com \
--cc=stable@vger.kernel.org \
--cc=tee.min.tan@intel.com \
--cc=tee.min.tan@linux.intel.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.