From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74339C433FE for ; Sat, 14 May 2022 21:55:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-365-xoKoxVkoPuCB8l3F11QeZQ-1; Sat, 14 May 2022 17:55:04 -0400 X-MC-Unique: xoKoxVkoPuCB8l3F11QeZQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D8807101AA44; Sat, 14 May 2022 21:55:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7E09400DFA2; Sat, 14 May 2022 21:55:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 75654194704E; Sat, 14 May 2022 21:55:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CFAE91947040 for ; Sat, 14 May 2022 21:55:01 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C1A9F403152; Sat, 14 May 2022 21:55:01 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDA8A416385 for ; Sat, 14 May 2022 21:55:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A32D83802B92 for ; Sat, 14 May 2022 21:55:01 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-LDH8RS2_N-CMrbf9HC_gFQ-1; Sat, 14 May 2022 17:54:59 -0400 X-MC-Unique: LDH8RS2_N-CMrbf9HC_gFQ-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6532FB80B23; Sat, 14 May 2022 21:54:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32777C340EE; Sat, 14 May 2022 21:54:56 +0000 (UTC) Date: Sat, 14 May 2022 23:54:53 +0200 From: Greg KH To: Shreenidhi Shedi Subject: Re: [PATCH 4/5] audit: remove redundant data_len check Message-ID: References: <20220514211455.284782-1-sshedi@vmware.com> <20220514211455.284782-4-sshedi@vmware.com> MIME-Version: 1.0 In-Reply-To: <20220514211455.284782-4-sshedi@vmware.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shreenidhi Shedi , linux-kernel@vger.kernel.org, eparis@redhat.com, linux-audit@redhat.com, arnd@arndb.de Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, May 15, 2022 at 02:44:54AM +0530, Shreenidhi Shedi wrote: > Signed-off-by: Shreenidhi Shedi > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 7690c29d4ee4..0749211d5552 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1390,7 +1390,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) > str); > } else { > audit_log_format(ab, " data="); > - if (data_len > 0 && str[data_len - 1] == '\0') > + if (str[data_len - 1] == '\0') > data_len--; > audit_log_n_untrustedstring(ab, str, data_len); > } > -- > 2.36.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F22C433EF for ; Sat, 14 May 2022 21:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235760AbiENVzj (ORCPT ); Sat, 14 May 2022 17:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235590AbiENVzE (ORCPT ); Sat, 14 May 2022 17:55:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19AF12E0BB for ; Sat, 14 May 2022 14:54:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C9C9FB80B26 for ; Sat, 14 May 2022 21:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32777C340EE; Sat, 14 May 2022 21:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652565296; bh=gMJSb4CxmhTgLpKS0+r2BvvEYboNlZJAypNpnjTCGXs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eq401OiH3ESQoLBSj2mq35okhw4v0nh2XeeTyW/KIO1UQD2JbyBKGxJKZQXOiv9GH fk3z+28GiD6Z2wpSMUPVcLUHUvSUQmr52pifXcAIPyUSlwaRk0AM+BcGfIqLH4jMNg YwP4oR+x+CddChWL9KaTNNVq+gphnNwq/XgE1ths= Date: Sat, 14 May 2022 23:54:53 +0200 From: Greg KH To: Shreenidhi Shedi Cc: arnd@arndb.de, paul@paul-moore.com, eparis@redhat.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, Shreenidhi Shedi Subject: Re: [PATCH 4/5] audit: remove redundant data_len check Message-ID: References: <20220514211455.284782-1-sshedi@vmware.com> <20220514211455.284782-4-sshedi@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220514211455.284782-4-sshedi@vmware.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 15, 2022 at 02:44:54AM +0530, Shreenidhi Shedi wrote: > Signed-off-by: Shreenidhi Shedi > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 7690c29d4ee4..0749211d5552 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1390,7 +1390,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) > str); > } else { > audit_log_format(ab, " data="); > - if (data_len > 0 && str[data_len - 1] == '\0') > + if (str[data_len - 1] == '\0') > data_len--; > audit_log_n_untrustedstring(ab, str, data_len); > } > -- > 2.36.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot