From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Chancellor Subject: Re: [linux-next:master 9995/11651] fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (1024) in 'block_read_full_folio' Date: Sat, 14 May 2022 14:57:18 -0700 Message-ID: References: <202205150051.3RzuooAG-lkp@intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652565440; bh=7/bA4w4G8YLE2TIhdgRqh26nw+jS5nqBcytlMpBLt6c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sLvjaR/bAqfxtbZbegiNJzcBeRj8fW3Pok6tKrFToxFQmVLDB2F6lMMHXRdMK/g2g nm8R7ZUJTaSHGZSllh/ylnHppOPM5fcHDcmpx3H6nyWUTwEk7YDeeiJKE71yuFYyNG mkF2qKCl18lDy1IcJZYwAJIvfPBYevDFdNWXQlFmJSufcl04mnF85bTkmxHmhpmikw ArJStkUXtR8NNb6n44njMt94gjJ14qC/T8sZ/Zv8wihkQuRNECoqQ9pGFw+FUUcqUl TX03OufZuA+Qy/xEG904myMtwQJTgtVIwBVkGDGm8i26ZbyVe11FgeWDx7o4qxyIyH 5S/pwvvAuwVgQ== Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="utf-8" To: Matthew Wilcox , Brian Cain Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-hexagon@vger.kernel.org On Sat, May 14, 2022 at 05:28:33PM +0100, Matthew Wilcox wrote: > On Sun, May 15, 2022 at 12:23:46AM +0800, kernel test robot wrote: > > commit: 2c69e2057962b6bd76d72446453862eb59325b49 [9995/11651] fs: Convert block_read_full_page() to block_read_full_folio() > > config: hexagon-randconfig-r041-20220513 (https://download.01.org/0day-ci/archive/20220515/202205150051.3RzuooAG-lkp@intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 38189438b69ca27b4c6ce707c52dbd217583d046) > ... > > All warnings (new ones prefixed by >>): > > > > >> fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (1024) in 'block_read_full_folio' [-Wframe-larger-than] > > int block_read_full_folio(struct folio *folio, get_block_t *get_block) > > ^ > > 1 warning generated. > > Now show the warnings that were removed. This patch renames the > function, and I bet there was a similar warning before this patch. > > But basically, I don't care about stack usage on hexagon with clang. > AIUI, it's a known bug. For what it's worth, it seems like this is just 256K pages being 256K pages... MAX_BUF_PER_PAGE is PAGE_SIZE / 512 so *arr is 2048 bytes big in this configuration. You'd see a similar warning with PowerPC but that configuration is non-standard: fs/buffer.c: In function ‘block_read_full_page’: fs/buffer.c:2337:1: warning: the frame size of 2064 bytes is larger than 1024 bytes [-Wframe-larger-than=] 2337 | } | ^ It would be nice if the Intel folks could look at recognizing a function rename so that you are not bothered by reports like this. As a side note... Brian, is there any reason for 256K pages to exist for Hexagon? This has been an option since Hexagon's introduction but is it actually used? 4K pages is the default and the help text says "use with caution". Perhaps the choice should be turned off altogether for CONFIG_COMPILE_TEST so that we cannot select this configuration and bother developers with these reports. Cheers, Nathan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4593353856249580014==" MIME-Version: 1.0 From: Nathan Chancellor To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 9995/11651] fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (1024) in 'block_read_full_folio' Date: Sat, 14 May 2022 14:57:18 -0700 Message-ID: In-Reply-To: List-Id: --===============4593353856249580014== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Sat, May 14, 2022 at 05:28:33PM +0100, Matthew Wilcox wrote: > On Sun, May 15, 2022 at 12:23:46AM +0800, kernel test robot wrote: > > commit: 2c69e2057962b6bd76d72446453862eb59325b49 [9995/11651] fs: Conve= rt block_read_full_page() to block_read_full_folio() > > config: hexagon-randconfig-r041-20220513 (https://download.01.org/0day-= ci/archive/20220515/202205150051.3RzuooAG-lkp(a)intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 38= 189438b69ca27b4c6ce707c52dbd217583d046) > ... > > All warnings (new ones prefixed by >>): > > = > > >> fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (= 1024) in 'block_read_full_folio' [-Wframe-larger-than] > > int block_read_full_folio(struct folio *folio, get_block_t *get_bloc= k) > > ^ > > 1 warning generated. > = > Now show the warnings that were removed. This patch renames the > function, and I bet there was a similar warning before this patch. > = > But basically, I don't care about stack usage on hexagon with clang. > AIUI, it's a known bug. For what it's worth, it seems like this is just 256K pages being 256K pages... MAX_BUF_PER_PAGE is PAGE_SIZE / 512 so *arr is 2048 bytes big in this configuration. You'd see a similar warning with PowerPC but that configuration is non-standard: fs/buffer.c: In function =E2=80=98block_read_full_page=E2=80=99: fs/buffer.c:2337:1: warning: the frame size of 2064 bytes is larger than 10= 24 bytes [-Wframe-larger-than=3D] 2337 | } | ^ It would be nice if the Intel folks could look at recognizing a function rename so that you are not bothered by reports like this. As a side note... Brian, is there any reason for 256K pages to exist for Hexagon? This has been an option since Hexagon's introduction but is it actually used? 4K pages is the default and the help text says "use with caution". Perhaps the choice should be turned off altogether for CONFIG_COMPILE_TEST so that we cannot select this configuration and bother developers with these reports. Cheers, Nathan --===============4593353856249580014==--