From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1157BC433F5 for ; Sun, 15 May 2022 09:46:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 732F149EEB; Sun, 15 May 2022 05:46:19 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UKgPlNjO2rZZ; Sun, 15 May 2022 05:46:18 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3A4AF4B0BA; Sun, 15 May 2022 05:46:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DC73E49EEB for ; Sun, 15 May 2022 05:46:16 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ufSmSXjKgJJ2 for ; Sun, 15 May 2022 05:46:12 -0400 (EDT) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9DA8549EE6 for ; Sun, 15 May 2022 05:46:12 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 729DAB80B42; Sun, 15 May 2022 09:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D9EC385B8; Sun, 15 May 2022 09:46:07 +0000 (UTC) Date: Sun, 15 May 2022 10:46:03 +0100 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH] KVM: arm64: vgic-v3: List M1 Pro/Max as requiring the SEIS workaround Message-ID: References: <20220514102524.3188730-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220514102524.3188730-1-maz@kernel.org> Cc: kernel-team@android.com, Will Deacon , marcan@marcan.st, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Sat, May 14, 2022 at 11:25:24AM +0100, Marc Zyngier wrote: > Unsusprisingly, Apple M1 Pro/Max have the exact same defect as the > original M1 and generate random SErrors in the host when a guest > tickles the GICv3 CPU interface the wrong way. > > Add the part numbers for both the CPU types found in these two > new implementations, and add them to the hall of shame. This also > applies to the Ultra version, as it is composed of 2 Max SoCs. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/cputype.h | 8 ++++++++ > arch/arm64/kvm/vgic/vgic-v3.c | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h > index ff8f4511df71..60647bdc0b09 100644 > --- a/arch/arm64/include/asm/cputype.h > +++ b/arch/arm64/include/asm/cputype.h > @@ -118,6 +118,10 @@ > > #define APPLE_CPU_PART_M1_ICESTORM 0x022 > #define APPLE_CPU_PART_M1_FIRESTORM 0x023 > +#define APPLE_CPU_PART_M1_ICESTORM_PRO 0x024 > +#define APPLE_CPU_PART_M1_FIRESTORM_PRO 0x025 > +#define APPLE_CPU_PART_M1_ICESTORM_MAX 0x028 > +#define APPLE_CPU_PART_M1_FIRESTORM_MAX 0x029 > > #define MIDR_CORTEX_A53 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A53) > #define MIDR_CORTEX_A57 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A57) > @@ -164,6 +168,10 @@ > #define MIDR_HISI_TSV110 MIDR_CPU_MODEL(ARM_CPU_IMP_HISI, HISI_CPU_PART_TSV110) > #define MIDR_APPLE_M1_ICESTORM MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM) > #define MIDR_APPLE_M1_FIRESTORM MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM) > +#define MIDR_APPLE_M1_ICESTORM_PRO MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM_PRO) > +#define MIDR_APPLE_M1_FIRESTORM_PRO MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM_PRO) > +#define MIDR_APPLE_M1_ICESTORM_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM_MAX) > +#define MIDR_APPLE_M1_FIRESTORM_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM_MAX) Acked-by: Catalin Marinas _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A686C433EF for ; Sun, 15 May 2022 09:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A2ySsNPJ74P5uYUQh4Fw7DgaHGaBUEZwgbTTMOPW3M8=; b=43LEIH9y4PUMkc 5EuivzMf+RbBeyxHk0pJZ2JFt/O3kiyk3N/cZb92QDydjTn18l91tiaFK090bDWNtkjzgtJAMJvfZ nb/kOxpuN/PB3xrIKfXVs3t3QRx0RfqT8aspSFWihXn7WMm/zIv+gHGwHGHRq+oAyQVGa+tkTwnuX t3jbONg47H5oEKxxR80FBKdVHnca13ug115T5BIb2Jqx3DhEjFr9y8CiM5uvMvB18MEo4ogWJcF4D XUYp55icGPmyWNwq3Tk96be+I6+KNZVOPoVUFB82RrnHWOWE/C4wRlwrI/l5CCw8n/V56TPNOoiTf 1HBMZjoQ416b3X+vh+vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqApN-003d0s-6Y; Sun, 15 May 2022 09:46:17 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqApI-003cxi-Kw for linux-arm-kernel@lists.infradead.org; Sun, 15 May 2022 09:46:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 729DAB80B42; Sun, 15 May 2022 09:46:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D9EC385B8; Sun, 15 May 2022 09:46:07 +0000 (UTC) Date: Sun, 15 May 2022 10:46:03 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Alexandru Elisei , Will Deacon , marcan@marcan.st, kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: vgic-v3: List M1 Pro/Max as requiring the SEIS workaround Message-ID: References: <20220514102524.3188730-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220514102524.3188730-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220515_024612_870345_706CC7AD X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 14, 2022 at 11:25:24AM +0100, Marc Zyngier wrote: > Unsusprisingly, Apple M1 Pro/Max have the exact same defect as the > original M1 and generate random SErrors in the host when a guest > tickles the GICv3 CPU interface the wrong way. > > Add the part numbers for both the CPU types found in these two > new implementations, and add them to the hall of shame. This also > applies to the Ultra version, as it is composed of 2 Max SoCs. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/cputype.h | 8 ++++++++ > arch/arm64/kvm/vgic/vgic-v3.c | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h > index ff8f4511df71..60647bdc0b09 100644 > --- a/arch/arm64/include/asm/cputype.h > +++ b/arch/arm64/include/asm/cputype.h > @@ -118,6 +118,10 @@ > > #define APPLE_CPU_PART_M1_ICESTORM 0x022 > #define APPLE_CPU_PART_M1_FIRESTORM 0x023 > +#define APPLE_CPU_PART_M1_ICESTORM_PRO 0x024 > +#define APPLE_CPU_PART_M1_FIRESTORM_PRO 0x025 > +#define APPLE_CPU_PART_M1_ICESTORM_MAX 0x028 > +#define APPLE_CPU_PART_M1_FIRESTORM_MAX 0x029 > > #define MIDR_CORTEX_A53 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A53) > #define MIDR_CORTEX_A57 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A57) > @@ -164,6 +168,10 @@ > #define MIDR_HISI_TSV110 MIDR_CPU_MODEL(ARM_CPU_IMP_HISI, HISI_CPU_PART_TSV110) > #define MIDR_APPLE_M1_ICESTORM MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM) > #define MIDR_APPLE_M1_FIRESTORM MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM) > +#define MIDR_APPLE_M1_ICESTORM_PRO MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM_PRO) > +#define MIDR_APPLE_M1_FIRESTORM_PRO MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM_PRO) > +#define MIDR_APPLE_M1_ICESTORM_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_ICESTORM_MAX) > +#define MIDR_APPLE_M1_FIRESTORM_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M1_FIRESTORM_MAX) Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel