From: "Darrick J. Wong" <djwong@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] xfs: Remove duplicate include
Date: Sun, 15 May 2022 12:25:52 -0700 [thread overview]
Message-ID: <YoFTwGLupUVjzQve@magnolia> (raw)
In-Reply-To: <20220515131140.31281-1-jiapeng.chong@linux.alibaba.com>
On Sun, May 15, 2022 at 09:11:40PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./fs/xfs/xfs_attr_item.c: xfs_inode.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_attr_item.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
> index e8ac88d9fd14..bf9a01b083b8 100644
> --- a/fs/xfs/xfs_attr_item.c
> +++ b/fs/xfs/xfs_attr_item.c
> @@ -22,7 +22,6 @@
> #include "xfs_attr.h"
> #include "xfs_attr_item.h"
> #include "xfs_trace.h"
> -#include "xfs_inode.h"
> #include "xfs_trans_space.h"
> #include "xfs_errortag.h"
> #include "xfs_error.h"
> --
> 2.20.1.7.g153144c
>
next prev parent reply other threads:[~2022-05-15 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 13:11 [PATCH] xfs: Remove duplicate include Jiapeng Chong
2022-05-15 19:25 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-24 7:47 Jiapeng Chong
2023-08-24 16:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoFTwGLupUVjzQve@magnolia \
--to=djwong@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.